This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Support PowerPC SPE musl dynamic linker name ld-musl-powerpc-sf.so.1
ClosedPublic

Authored by pattop on Jul 12 2021, 10:03 PM.

Details

Summary

Musl treats PowerPC SPE as a soft-float target (as the PowerPC SPE ABI
is soft-float compatible).

Diff Detail

Event Timeline

pattop created this revision.Jul 12 2021, 10:03 PM
pattop requested review of this revision.Jul 12 2021, 10:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 10:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I personally don't see anything wrong with this, but then again I am not really familiar with SPE. I'll defer to @jhibbits for the approval.

jhibbits accepted this revision.Jul 16 2021, 7:02 AM

Looks fine to me. @nemanjai this one is more Musl, less SPE :)

This revision is now accepted and ready to land.Jul 16 2021, 7:02 AM
MaskRay requested changes to this revision.Nov 26 2021, 1:37 PM
MaskRay added a subscriber: MaskRay.

This needs a test like clang/test/Driver/linux-ld.c CHECK-MUSL-PPC. Use ninja check-clang-driver to test.

This revision now requires changes to proceed.Nov 26 2021, 1:37 PM
pattop updated this revision to Diff 390227.Nov 28 2021, 3:24 PM

Add test case.

MaskRay accepted this revision.Nov 28 2021, 3:33 PM

I have confirmed that this matches musl #define FP_SUFFIX "-sf"

This revision is now accepted and ready to land.Nov 28 2021, 3:33 PM
MaskRay retitled this revision from [Driver] fix PowerPC SPE musl dynamic linker name to [Driver] Support PowerPC SPE musl dynamic linker name ld-musl-powerpc-sf.so.1.Nov 28 2021, 3:34 PM
This revision was landed with ongoing or failed builds.Nov 28 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.