Page MenuHomePhabricator

WebAssembly: Update datalayout to match fp128 ABI change
ClosedPublic

Authored by dschuff on Jul 9 2021, 3:45 PM.

Details

Summary

This fix goes along with d1a96e906cc03a95cfd41a1f22bdda92651250c7
and makes the fp128 alignment match clang's long double alignment.

Diff Detail

Event Timeline

dschuff created this revision.Jul 9 2021, 3:45 PM
dschuff requested review of this revision.Jul 9 2021, 3:45 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 9 2021, 3:45 PM

This fix should go in ASAP (or else we should revert d1a96e906cc03a95cfd41a1f22bdda92651250c7) to fix the mismatch between LLVM and clang.

kripken added a subscriber: kripken.Jul 9 2021, 4:01 PM
kripken added inline comments.
clang/lib/Basic/Targets/WebAssembly.h
175

Should this not be

resetDataLayout("e-m:e-p:64:64-i64:64-f128:64-n32:64-S128-ni:1");

(that is, the first two numbers should be 64?)

dschuff updated this revision to Diff 357665.Jul 9 2021, 4:30 PM
  • fix wasm64 copypasta
clang/lib/Basic/Targets/WebAssembly.h
175

oops yes, that's a copypasta

dschuff marked an inline comment as done.Jul 9 2021, 4:45 PM
kripken accepted this revision.Jul 9 2021, 4:45 PM
This revision is now accepted and ready to land.Jul 9 2021, 4:45 PM
This revision was landed with ongoing or failed builds.Jul 9 2021, 4:52 PM
This revision was automatically updated to reflect the committed changes.
sunfish added inline comments.Jul 9 2021, 6:35 PM
llvm/test/CodeGen/WebAssembly/varargs.ll
5

It appears this change means that we're no longer testing varargs on wasm32-unknown-unknown. Please update this test so that it tests both triples.

dschuff added inline comments.Jul 13 2021, 2:32 PM
llvm/test/CodeGen/WebAssembly/varargs.ll
5