This is an archive of the discontinued LLVM Phabricator instance.

Differential D105744

[NFC][compiler-rt][hwasan] Move shadow bound variables to hwasan.cpp
ClosedPublic

Authored by leonardchan on Jul 9 2021, 3:12 PM.

Details

Reviewers
vitalybuka
eugenis
Commits
rGb270c3fbdeae: [NFC][compiler-rt][hwasan] Move shadow bound variables to hwasan.cpp
Summary

This way, other platforms can define these values.

Diff Detail

Event Timeline

leonardchan created this revision.Jul 9 2021, 3:12 PM
Herald added a subscriber: dberris. · View Herald TranscriptJul 9 2021, 3:12 PM
leonardchan requested review of this revision.Jul 9 2021, 3:12 PM
leonardchan added a child revision: D105745: [compiler-rt][hwasan][fuchsia] Define shadow bound globals.Jul 9 2021, 3:18 PM
vitalybuka accepted this revision.Jul 9 2021, 3:28 PM
This revision is now accepted and ready to land.Jul 9 2021, 3:28 PM
Harbormaster completed remote builds in B113305: Diff 357651.Jul 9 2021, 5:19 PM
• post.kadirselcuk added a child revision: D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".Jul 10 2021, 5:55 PM
• post.kadirselcuk added a parent revision: D105762: [X86] Teach X86FloatingPoint's handleCall to only erase the FP stack if there is a regmask operand that clobbers the FP stack..Jul 10 2021, 8:06 PM
craig.topper removed a parent revision: D105762: [X86] Teach X86FloatingPoint's handleCall to only erase the FP stack if there is a regmask operand that clobbers the FP stack..Jul 10 2021, 9:47 PM
Closed by commit rGb270c3fbdeae: [NFC][compiler-rt][hwasan] Move shadow bound variables to hwasan.cpp (authored by leonardchan). · Explain WhyJul 12 2021, 10:16 AM
This revision was automatically updated to reflect the committed changes.
leonardchan added a commit: rGb270c3fbdeae: [NFC][compiler-rt][hwasan] Move shadow bound variables to hwasan.cpp.
efriedma removed a child revision: D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".Jul 17 2021, 3:02 PM

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
5 lines
4 lines

Diff 357651

compiler-rt/lib/hwasan/hwasan.cpp

Context not available.
int hwasan_report_count = 0; int hwasan_report_count = 0;
uptr kLowShadowStart;
uptr kLowShadowEnd;
uptr kHighShadowStart;
uptr kHighShadowEnd;
void Flags::SetDefaults() { void Flags::SetDefaults() {
#define HWASAN_FLAG(Type, Name, DefaultValue, Description) Name = DefaultValue; #define HWASAN_FLAG(Type, Name, DefaultValue, Description) Name = DefaultValue;
#include "hwasan_flags.inc" #include "hwasan_flags.inc"
Context not available.

compiler-rt/lib/hwasan/hwasan_linux.cpp

Context not available.
uptr kLowMemStart; uptr kLowMemStart;
uptr kLowMemEnd; uptr kLowMemEnd;
uptr kLowShadowEnd;
uptr kLowShadowStart;
uptr kHighShadowStart;
uptr kHighShadowEnd;
uptr kHighMemStart; uptr kHighMemStart;
uptr kHighMemEnd; uptr kHighMemEnd;
Context not available.