This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][hwasan][Fuchsia] Do not emit FindDynamicShadowStart for Fuchsia
ClosedPublic

Authored by leonardchan on Jul 9 2021, 2:06 PM.

Details

Summary

This function is unused because fuchsia does not support a dynamic shadow.

Diff Detail

Event Timeline

leonardchan created this revision.Jul 9 2021, 2:06 PM
leonardchan requested review of this revision.Jul 9 2021, 2:06 PM

I think it would be more in keeping with local style to make this a third #elif SANITIZER_FUCHSIA leg in the middle with the InitShadowGOT stub. FindDynamicShadowStart is only called from Linux-specific code and does not need to be defined.

I think it would be more in keeping with local style to make this a third #elif SANITIZER_FUCHSIA leg in the middle with the InitShadowGOT stub. FindDynamicShadowStart is only called from Linux-specific code and does not need to be defined.

Something like this?

mcgrathr accepted this revision.Jul 27 2021, 1:15 PM

lgtm

compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp
116

Put blank lines around #if et al.

This revision is now accepted and ready to land.Jul 27 2021, 1:15 PM
This revision was landed with ongoing or failed builds.Jul 27 2021, 3:47 PM
This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.