Page MenuHomePhabricator

Add AddDiscriminatorsPass to NPM default O0 pipeline
ClosedPublic

Authored by ychen on Jul 8 2021, 12:23 PM.

Details

Summary

AddDiscriminatorsPass is in Legacy PM's O0 pipeline. This patch did the same
for NPM O0 pipeline.

Diff Detail

Event Timeline

ychen created this revision.Jul 8 2021, 12:23 PM
ychen requested review of this revision.Jul 8 2021, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2021, 12:23 PM
aeubanks accepted this revision.Jul 8 2021, 1:24 PM

lgtm

This revision is now accepted and ready to land.Jul 8 2021, 1:24 PM
MaskRay accepted this revision.Jul 8 2021, 2:51 PM
MaskRay added a subscriber: MaskRay.

I assume this will make sample PGO usable with -O0?

ychen added a comment.Jul 8 2021, 3:55 PM

I assume this will make sample PGO usable with -O0?

That's right. The issue was found while trying to use sample PGO with O0.

This revision was automatically updated to reflect the committed changes.