Add AddDiscriminatorsPass to NPM default O0 pipeline
ClosedPublic
Actions

Authored by ychen on Jul 8 2021, 12:23 PM.

Details

Reviewers

aeubanks
MaskRay

Commits

rG0eb2b13d609c: Add AddDiscriminatorsPass to NPM default O0 pipeline

Summary

AddDiscriminatorsPass is in Legacy PM's O0 pipeline. This patch did the same
for NPM O0 pipeline.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ychen created this revision.Jul 8 2021, 12:23 PM

Herald added subscribers: ormris, hiraditya. · View Herald TranscriptJul 8 2021, 12:23 PM

ychen requested review of this revision.Jul 8 2021, 12:23 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2021, 12:23 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

lgtm

This revision is now accepted and ready to land.Jul 8 2021, 1:24 PM

Harbormaster completed remote builds in B113062: Diff 357319.Jul 8 2021, 1:55 PM

I assume this will make sample PGO usable with -O0?

In D105650#2865669, @MaskRay wrote:

I assume this will make sample PGO usable with -O0?

That's right. The issue was found while trying to use sample PGO with O0.

Closed by commit rG0eb2b13d609c: Add AddDiscriminatorsPass to NPM default O0 pipeline (authored by ychen). · Explain WhyJul 8 2021, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ychen added a commit: rG0eb2b13d609c: Add AddDiscriminatorsPass to NPM default O0 pipeline.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Passes/

PassBuilder.cpp

4 lines

test/

Other/

new-pm-O0-defaults.ll

7 lines

Diff 357384

View Options

llvm/lib/Passes/PassBuilder.cpp