This is an archive of the discontinued LLVM Phabricator instance.

[NewPM] Rename 'unswitch' to 'simple-loop-unswitch' in PassRegistry
ClosedPublic

Authored by bjope on Jul 8 2021, 6:24 AM.

Details

Summary

It is confusing to have two ways of specifying the same pass
('simple-loop-unswitch' and 'unswitch'). This patch replaces
'unswitch' by 'simple-loop-unswitch' to get a unique identifier.

Using 'simple-loop-unswitch' instead of 'unswitch' also has the
advantage of matching how the pass is named in DEBUG_TYPE etc. So
this makes it a bit more consistent how we refer to the pass in
options such as -passes, -print-after and -debug-only.

Diff Detail

Event Timeline

bjope created this revision.Jul 8 2021, 6:24 AM
bjope requested review of this revision.Jul 8 2021, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2021, 6:24 AM
aeubanks accepted this revision.Jul 8 2021, 8:46 AM

I think at some point we'll want to remove the old unswitch pass and rename this one to "unswitch" or "loop-unswitch"
but for now this lgtm

This revision is now accepted and ready to land.Jul 8 2021, 8:46 AM
This revision was landed with ongoing or failed builds.Jul 9 2021, 12:59 AM
This revision was automatically updated to reflect the committed changes.