This is an archive of the discontinued LLVM Phabricator instance.

Differential D105559

[lld-macho][nfc] Rename test file to be more descriptive (rather than referencing the bug number)
ClosedPublic

Authored by oontvoo on Jul 7 2021, 9:37 AM.

Details

Reviewers
gkm
MaskRay
dblaikie
int3
Group Reviewers
Restricted Project
Commits
rGe25a384055fc: [lld-macho][nfc] Rename test file to be more descriptive (rather than…

Diff Detail

Event Timeline

oontvoo created this revision.Jul 7 2021, 9:37 AM
Herald added a reviewer: gkm. · View Herald TranscriptJul 7 2021, 9:37 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
oontvoo requested review of this revision.Jul 7 2021, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 9:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
oontvoo mentioned this in rGbf7f846b6830: Fix test so it doesn't try to write to the test directory, only to %t.Jul 7 2021, 9:38 AM
oontvoo added reviewers: MaskRay, dblaikie.
int3 accepted this revision.Jul 7 2021, 10:05 AM
int3 added a subscriber: int3.

nit 1: use hyphens for separators, like the rest of the test files
nit 2: could use 'stabs' instead of 'debug symbols' -- we already have a test named stabs.s

This revision is now accepted and ready to land.Jul 7 2021, 10:05 AM
Harbormaster completed remote builds in B112801: Diff 356982.Jul 7 2021, 10:06 AM
oontvoo updated this revision to Diff 356990.Jul 7 2021, 10:13 AM

rename to "obj-file-with-stas"

This revision was landed with ongoing or failed builds.Jul 7 2021, 10:16 AM
Closed by commit rGe25a384055fc: [lld-macho][nfc] Rename test file to be more descriptive (rather than… (authored by oontvoo). · Explain Why
This revision was automatically updated to reflect the committed changes.
oontvoo added a commit: rGe25a384055fc: [lld-macho][nfc] Rename test file to be more descriptive (rather than….
oontvoo added a comment.Jul 7 2021, 10:17 AM
In D105559#2862216, @oontvoo wrote:

rename to "obj-file-with-stas"

P.S: the comment is mistyped but the filename wasn't.

Harbormaster completed remote builds in B112808: Diff 356990.Jul 7 2021, 10:49 AM

Revision Contents

PathSize
lld/
test/
MachO/

Diff 356991

lld/test/MachO/bug_50812.s

  • This file was moved to lld/test/MachO/obj-file-with-stabs.s.

lld/test/MachO/obj-file-with-stabs.s

  • This file was moved from lld/test/MachO/bug_50812.s.
The contents of this file were not changed.