This patch defines the macro __LONGDOUBLE64 for AIX when long double is 8 bytes.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Basic/Targets/PPC.cpp | ||
---|---|---|
299 | I suggest querying the -mlong-double-64 option and asserting that the LongDoubleWidth is 64. |
Comment Actions
The change made me think we should add the negative test with -mlong-double-128, but then I thought we should probably make that an error until we've sorted through the AIX binary compat implications and tested it. So the patch you've proposed makes sense to me and we should follow up with handling for mlong-double-128.
Comment Actions
The decision was made to make -mlong-double-128 an error on AIX: https://reviews.llvm.org/D106074 [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.
So I think your patch is ready to land. LGTM.
I suggest querying the -mlong-double-64 option and asserting that the LongDoubleWidth is 64.