This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Gated calls to getAsm{Result,BlockArgument}Names on whether printing ops in generic form.
ClosedPublic

Authored by izuk on Jul 1 2021, 11:00 AM.

Details

Reviewers
rriddle
mehdi_amini
Commits
rG0813bd1696dc: [Polly][Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC
rGc476566be5d0: [IRForTarget] Don't pass nullptr to GetElementPtrInst::Create() (NFC)
rGb00cff56cfb1: Reapply [IR] Don't accept nullptr as GEP element type
rGb379ab41937f: [AMDGPU] Add VOP rematerialization test. NFC.
rGecd15fbf6bb5: [ARC][NFC] Include file re-ordering
rG5511bfdb6715: [hwasan] More realistic setjmp test.
rGf8bef4734845: [libcxx][CI] Work around Arm buildkite failures
rGc2b7f09d8c27: [SLP] make invalid operand explicit for extra arg in reduction matching; NFC
rG86e65234404f: [SLP] add tests for poison-safe logical reductions; NFC
rG55c5c0485924: [PhaseOrdering] add tests for vector cmp reductions; NFC
rG2e3f4694d61d: [IR] Add GEPOperator::indices() (NFC)
rG488fcea3b552: [lldb] Use custom script instead of lldb.macosx.crashlog in test
rG4a3b0556536d: [AMDGPU] Fix flags of V_MOV_B64_PSEUDO
rGab8989ab8710: [OPENMP]Fix overlapped mapping for dereferenced pointer members.
rG3e97d11df8ce: [AMDGPU] Added v_accvgpr_read_b32 rematerialization test. NFC.
rG3338819b08fa: [lldb] Drop REQUIRES where redundant because of lit.local.cfg
rGd124133f1735: Add scoped timers to ReadMemoryFromInferior and ReadMemoryFromFileCache.
rG9a9bc76c0eb7: Prepare Compiler-RT for GnuInstallDirs, matching libcxx
rG0562d1786483: PR51018: A few more explicit conversions from SmallString to StringRef
rG9647a6f719ee: [WebAssembly] Added initial type checker to MC Assembler
rG47aeeffc8fb4: [GlobalISel] Use GCDTy when extracting GCD ty from leftover regs in insertParts
rGccb10266f56b: [HIP] Move std headers after device malloc/free
rG156cb8d5ca67: [WebAssembly] fix broken tools/llvm-symbolizer/wasm-basic.s test
rGf3e6c3f327c2: [WebAssembly] Fixed 2 warnings in Asm Type Checker
rG10cb03622325: [llvm-mca] Refactor the logic that prints JSON files.
rG1a4d1315650b: [llvm-nm][test] diff -q => diff to make AIX happy
rGc82b96c0a414: [gn build] fix formatting after 9647a6f719ee
rG5f306feb4d3f: [WebAssembly] Fix warnings
rG49d66d9f9f49: [AFDO] Merge function attributes after inlining
rGfc01fafa3e7f: [MLIR][GPU][NFC] Fix documentation for wmma matrix load/store ops
rGac02baab48c2: WebAssembly: Update datalayout to match fp128 ABI change
rG8e9216fe877c: [SLP] Do not make an attempt to match reduction on already erased instruction.
rG9c4baf5101e9: [ScalarEvolution] Strictly enforce pointer/int type rules.
rGd67cbe8b31a9: Unreachable (removed)
rGdb4c25822a1d: [scudo] Check if we use __clang_major__ >= 12
rG882ee7fbd6fc: Fix buildbot regression from 9c4baf5.
rG04c203e310bd: llvm-symbolizer: Fix "start file" to work with Split DWARF
rGe5220104d070: [WebAssembly] Custom combines for f64x2.promote_low_f32x4
rG3822e3d5b049: [lld-macho] Fix bug in handling unwind info from ld -r
rGb8e5f918166c: [ORC] Flesh out ExecutorAddress, rename CommonOrcRuntimeTypes header.
rG58a2cb514366: [GlobalISel] Add a new artifact combiner for unmerge which looks through…
rG1f40870dda46: [NFC][ScalarEvolution] Precommit tests for D104075.
rG97c426394a71: [AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR.
rG8cf7ddbdd4e5: Revert "Prepare Compiler-RT for GnuInstallDirs, matching libcxx"
rG41b605764172: [InstructionCost] Add saturation support.
rG239fcda268dc: [LV] NFCI: Do cost comparison on InstructionCost directly.
rGd919bca87556: [llvm-mca][JSON] Further refactoring of the JSON printing logic.
rG8662e04552c2: Update arithmetic-fence-builtin.c
rG4fe0fcd1c032: [llvm-mca][JSON] Teach the PipelinePrinter how to deal with anonymous code…
rGa328ee657798: [X86] Add tests from D93707 for fsub_strict(x,fneg(y)) -> fadd_strict(x,y)…
rG8f4e5474de74: [AFDO] Require x86_64-linux in a testcase
rG1d0456361a42: [OpenMP] Avoid checking parent reference count in targetDataEnd
rGd99f65de2ab1: [OpenMP] Avoid checking parent reference count in targetDataBegin
rGf4f11ee4a705: [mlir][NFC] Switched `interfaces` to a private member of SSANameState.
rG2c0f17982f39: [mlir] Added OpPrintingFlags to AsmState and SSANameState.
rGbe5d46e9bbc9: [Attributor][FIX] Traverse uses even if a value is assumed constant
rG93a279a67dc0: [Attributor] Introduce an optimistic getUnderlyingObjects helper
rG374e573cfc2b: [Attributor] Use AAValueSimplify to simplify returned values
rG1eb31d6de36b: [Attributor] Reorganize AAHeapToStack
rG5003ba2542c1: [Attributor] Look through selects in genericValueTraversal
rG1d5711c3eeb6: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL
rGf0628c6ff7ba: [OpenMP] Create custom state machines for generic target regions
rGae08df87dfba: [Attributor][FIX] Do not replace a value with a non-dominating instruction
rG966342790e8d: [Attributor][FIX] Sanitize queries to LVI and ScalarEvolution
rGe603ca0306d7: [OpenMP] Remove checkXXXX device runtime functions
rGd39179d7fa17: [OpenMP] Detect SPMD compatible kernels and execute them as such
rG269416d41908: [Attributor][NFCI] Add UsedAssumedInformation to more interfaces
rG768510632c5d: Revert "llvm-symbolizer: Fix "start file" to work with Split DWARF"
rGf01d45c378cd: Reland "[clang-repl] Allow passing in code as positional arguments."
rGd3e749133319: Revert Attributor patch series
rG5b12cf3e659b: [Attributor][FIX] Traverse uses even if a value is assumed constant
rG0aab13aaf942: [Attributor] Introduce an optimistic getUnderlyingObjects helper
rG5ef18e242183: [Attributor] Use AAValueSimplify to simplify returned values
rGa6470408cf36: [ARM] Extra widening and narrowing combinations tests. NFC
rGdbb3a65f5b30: [Attributor][FIX] Do not replace a value with a non-dominating instruction
rG773beb6fbed7: Unreachable (removed)
rGc1c1fe93852e: [Attributor] Reorganize AAHeapToStack
rG5b05a5f6cee2: [OpenMP][FIX] Update remark in test file after rewording
rGc1d53a316d6c: [Attributor] Look through selects in genericValueTraversal
rG4761d29633ac: [Attributor][FIX] Sanitize queries to LVI and ScalarEvolution
rGe2cfbfcc0c1f: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL
rGd9659bf6a036: [OpenMP] Create custom state machines for generic target regions
rGa706b94ea556: [OpenMP][NFCI] Re-enable two remarks tests after D101977 landed
rG0a223827de8d: [OpenMP] Remove checkXXXX device runtime functions
rG8cb7d71355f9: [OpenMP][FIX] Add missing `)` to remark
rG514c033db1e0: [OpenMP] Detect SPMD compatible kernels and execute them as such
rG2e7e2994a94e: [Attributor][FIX] Destroy bump allocator objects to avoid leaks
rG86109fa9e84c: [RISCV] Add test cases for div/rem with constant left hand side. NFC
rG74f6e1614b85: Unreachable (removed)
rGf8b7fdc9319e: Unreachable (removed)
rTad57b9ae24df: SPEC2006: Pronounce endianness flags both ways
rG4f94121cce24: [Analysis] Remove changeCondBranchToUnconditionalTo (NFC)
rTd382dfd3c56a: [fpcmp] Fix memory leak. NFC.
rG99b8c4682865: [RISCV] Restore non-constant srem test I accidentally deleted. NFC
rGcbba7299f308: [DivRemPairs] Add test cases for D87555. NFC
rGb447b9dce0d1: Reapply "llvm-symbolizer: Fix "start file" to work with Split DWARF"
rG09cdcf09b54d: Fix windows directory separator some more for test from…
rGebbe149a6f08: [mlir] Gated calls to getAsm{Result,BlockArgument}Names on whether printing ops…
Summary

Depends On D105300

Diff Detail

Event Timeline

izuk created this revision.Jul 1 2021, 11:00 AM
izuk requested review of this revision.Jul 1 2021, 11:00 AM

I think this can be tested with the test dialect? We likely already have operation using the OpAsmOpInterface there for example

izuk updated this revision to Diff 356276.Jul 2 2021, 2:16 PM

No changes.

izuk retitled this revision from Gated calls to getAsm{Result,BlockArgument}Names on whether printing ops in generic form. to [mlir] Gated calls to getAsm{Result,BlockArgument}Names on whether printing ops in generic form..Jul 2 2021, 2:23 PM
izuk updated this revision to Diff 357296.Jul 8 2021, 11:25 AM

Added test for behaviour change: print-op-generic.mlir.

mehdi_amini accepted this revision.Jul 8 2021, 11:48 AM
This revision is now accepted and ready to land.Jul 8 2021, 11:48 AM
This revision was landed with ongoing or failed builds.Jul 10 2021, 10:20 AM
This revision was automatically updated to reflect the committed changes.
post.kadirselcuk added commits: rG09cdcf09b54d: Fix windows directory separator some more for test from…, rGb447b9dce0d1: Reapply "llvm-symbolizer: Fix "start file" to work with Split DWARF", rGcbba7299f308: [DivRemPairs] Add test cases for D87555. NFC, rG99b8c4682865: [RISCV] Restore non-constant srem test I accidentally deleted. NFC, rTd382dfd3c56a: [fpcmp] Fix memory leak. NFC., rG4f94121cce24: [Analysis] Remove changeCondBranchToUnconditionalTo (NFC), rTad57b9ae24df: SPEC2006: Pronounce endianness flags both ways, rGf8b7fdc9319e: Unreachable (removed), rG74f6e1614b85: Unreachable (removed), rG86109fa9e84c: [RISCV] Add test cases for div/rem with constant left hand side. NFC, rG2e7e2994a94e: [Attributor][FIX] Destroy bump allocator objects to avoid leaks, rG514c033db1e0: [OpenMP] Detect SPMD compatible kernels and execute them as such, rG8cb7d71355f9: [OpenMP][FIX] Add missing `)` to remark, rG0a223827de8d: [OpenMP] Remove checkXXXX device runtime functions, rGa706b94ea556: [OpenMP][NFCI] Re-enable two remarks tests after D101977 landed, rGd9659bf6a036: [OpenMP] Create custom state machines for generic target regions, rGe2cfbfcc0c1f: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL, rG4761d29633ac: [Attributor][FIX] Sanitize queries to LVI and ScalarEvolution, rGc1d53a316d6c: [Attributor] Look through selects in genericValueTraversal, rG5b05a5f6cee2: [OpenMP][FIX] Update remark in test file after rewording, rGc1c1fe93852e: [Attributor] Reorganize AAHeapToStack, rG773beb6fbed7: Unreachable (removed), rGdbb3a65f5b30: [Attributor][FIX] Do not replace a value with a non-dominating instruction, rGa6470408cf36: [ARM] Extra widening and narrowing combinations tests. NFC, rG5ef18e242183: [Attributor] Use AAValueSimplify to simplify returned values, rG0aab13aaf942: [Attributor] Introduce an optimistic getUnderlyingObjects helper, rG5b12cf3e659b: [Attributor][FIX] Traverse uses even if a value is assumed constant, rGd3e749133319: Revert Attributor patch series, rGf01d45c378cd: Reland "[clang-repl] Allow passing in code as positional arguments.", rG768510632c5d: Revert "llvm-symbolizer: Fix "start file" to work with Split DWARF", rG269416d41908: [Attributor][NFCI] Add UsedAssumedInformation to more interfaces, rGd39179d7fa17: [OpenMP] Detect SPMD compatible kernels and execute them as such, rGe603ca0306d7: [OpenMP] Remove checkXXXX device runtime functions, rG966342790e8d: [Attributor][FIX] Sanitize queries to LVI and ScalarEvolution, rGae08df87dfba: [Attributor][FIX] Do not replace a value with a non-dominating instruction, rGf0628c6ff7ba: [OpenMP] Create custom state machines for generic target regions, rG1d5711c3eeb6: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL, rG5003ba2542c1: [Attributor] Look through selects in genericValueTraversal, rG1eb31d6de36b: [Attributor] Reorganize AAHeapToStack, rG374e573cfc2b: [Attributor] Use AAValueSimplify to simplify returned values, rG93a279a67dc0: [Attributor] Introduce an optimistic getUnderlyingObjects helper, rGbe5d46e9bbc9: [Attributor][FIX] Traverse uses even if a value is assumed constant, rG2c0f17982f39: [mlir] Added OpPrintingFlags to AsmState and SSANameState., rGf4f11ee4a705: [mlir][NFC] Switched `interfaces` to a private member of SSANameState., rGd99f65de2ab1: [OpenMP] Avoid checking parent reference count in targetDataBegin, rG1d0456361a42: [OpenMP] Avoid checking parent reference count in targetDataEnd, rG8f4e5474de74: [AFDO] Require x86_64-linux in a testcase, rGa328ee657798: [X86] Add tests from D93707 for fsub_strict(x,fneg(y)) -> fadd_strict(x,y)…, rG4fe0fcd1c032: [llvm-mca][JSON] Teach the PipelinePrinter how to deal with anonymous code…, rG8662e04552c2: Update arithmetic-fence-builtin.c, rGd919bca87556: [llvm-mca][JSON] Further refactoring of the JSON printing logic., rG239fcda268dc: [LV] NFCI: Do cost comparison on InstructionCost directly., rG41b605764172: [InstructionCost] Add saturation support., rG8cf7ddbdd4e5: Revert "Prepare Compiler-RT for GnuInstallDirs, matching libcxx", rG97c426394a71: [AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR., rG1f40870dda46: [NFC][ScalarEvolution] Precommit tests for D104075., rG58a2cb514366: [GlobalISel] Add a new artifact combiner for unmerge which looks through…, rGb8e5f918166c: [ORC] Flesh out ExecutorAddress, rename CommonOrcRuntimeTypes header., rG3822e3d5b049: [lld-macho] Fix bug in handling unwind info from ld -r, rGe5220104d070: [WebAssembly] Custom combines for f64x2.promote_low_f32x4, rG04c203e310bd: llvm-symbolizer: Fix "start file" to work with Split DWARF, rG882ee7fbd6fc: Fix buildbot regression from 9c4baf5., rGdb4c25822a1d: [scudo] Check if we use __clang_major__ >= 12, rGd67cbe8b31a9: Unreachable (removed), rG9c4baf5101e9: [ScalarEvolution] Strictly enforce pointer/int type rules., rG8e9216fe877c: [SLP] Do not make an attempt to match reduction on already erased instruction., rGac02baab48c2: WebAssembly: Update datalayout to match fp128 ABI change, rGfc01fafa3e7f: [MLIR][GPU][NFC] Fix documentation for wmma matrix load/store ops, rG49d66d9f9f49: [AFDO] Merge function attributes after inlining, rG5f306feb4d3f: [WebAssembly] Fix warnings, rGc82b96c0a414: [gn build] fix formatting after 9647a6f719ee, rG1a4d1315650b: [llvm-nm][test] diff -q => diff to make AIX happy, rG10cb03622325: [llvm-mca] Refactor the logic that prints JSON files., rGf3e6c3f327c2: [WebAssembly] Fixed 2 warnings in Asm Type Checker, rG156cb8d5ca67: [WebAssembly] fix broken tools/llvm-symbolizer/wasm-basic.s test, rGccb10266f56b: [HIP] Move std headers after device malloc/free, rG47aeeffc8fb4: [GlobalISel] Use GCDTy when extracting GCD ty from leftover regs in insertParts, rG9647a6f719ee: [WebAssembly] Added initial type checker to MC Assembler, rG0562d1786483: PR51018: A few more explicit conversions from SmallString to StringRef, rG9a9bc76c0eb7: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, rGd124133f1735: Add scoped timers to ReadMemoryFromInferior and ReadMemoryFromFileCache., rG3338819b08fa: [lldb] Drop REQUIRES where redundant because of lit.local.cfg, rG3e97d11df8ce: [AMDGPU] Added v_accvgpr_read_b32 rematerialization test. NFC., rGab8989ab8710: [OPENMP]Fix overlapped mapping for dereferenced pointer members., rG4a3b0556536d: [AMDGPU] Fix flags of V_MOV_B64_PSEUDO, rG488fcea3b552: [lldb] Use custom script instead of lldb.macosx.crashlog in test, rG2e3f4694d61d: [IR] Add GEPOperator::indices() (NFC), rG55c5c0485924: [PhaseOrdering] add tests for vector cmp reductions; NFC, rG86e65234404f: [SLP] add tests for poison-safe logical reductions; NFC, rGc2b7f09d8c27: [SLP] make invalid operand explicit for extra arg in reduction matching; NFC, rGf8bef4734845: [libcxx][CI] Work around Arm buildkite failures, rG5511bfdb6715: [hwasan] More realistic setjmp test., rGecd15fbf6bb5: [ARC][NFC] Include file re-ordering, rGb379ab41937f: [AMDGPU] Add VOP rematerialization test. NFC., rGb00cff56cfb1: Reapply [IR] Don't accept nullptr as GEP element type, rGc476566be5d0: [IRForTarget] Don't pass nullptr to GetElementPtrInst::Create() (NFC), rG0813bd1696dc: [Polly][Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC.Jul 10 2021, 7:55 PM