This is an archive of the discontinued LLVM Phabricator instance.

Differential D105285

[Clang] Add test dependency on llvm-ar
ClosedPublic

Authored by saiislam on Jul 1 2021, 7:33 AM.

Details

Reviewers
rsmith
jdoerfert
yaxunl
Commits
rG94d5f2afbef0: [Clang] Add test dependency on llvm-ar
Summary

Following clang driver tests invoke llvm-ar, so ensure that
check-clang rebuilds llvm-ar.

  • test/Driver/clang-offload-bundler.c
  • test/Driver/hip-link-save-temps.hip
  • test/Driver/hip-link-static-library.hip
  • test/Driver/hip-toolchain-rdc-static-lib.hip

Diff Detail

Event Timeline

saiislam created this revision.Jul 1 2021, 7:33 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 1 2021, 7:33 AM
saiislam requested review of this revision.Jul 1 2021, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2021, 7:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
saiislam mentioned this in D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives.Jul 1 2021, 7:42 AM
Harbormaster completed remote builds in B111983: Diff 355877.Jul 1 2021, 8:40 AM
yaxunl accepted this revision.Jul 6 2021, 10:45 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Jul 6 2021, 10:45 AM
Closed by commit rG94d5f2afbef0: [Clang] Add test dependency on llvm-ar (authored by saiislam). · Explain WhyJul 7 2021, 2:01 AM
This revision was automatically updated to reflect the committed changes.
saiislam added a commit: rG94d5f2afbef0: [Clang] Add test dependency on llvm-ar.

Revision Contents

PathSize
clang/
test/
1 line

Diff 355877

clang/test/CMakeLists.txt

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Linesset(CLANG_TEST_PARAMS
USE_Z3_SOLVER=0 USE_Z3_SOLVER=0
) )
if( NOT CLANG_BUILT_STANDALONE ) if( NOT CLANG_BUILT_STANDALONE )
list(APPEND CLANG_TEST_DEPS list(APPEND CLANG_TEST_DEPS
llvm-config llvm-config
FileCheck count not FileCheck count not
llc llc
llvm-ar
llvm-as llvm-as
llvm-bcanalyzer llvm-bcanalyzer
llvm-cat llvm-cat
llvm-cxxfilt llvm-cxxfilt
llvm-dis llvm-dis
llvm-dwarfdump llvm-dwarfdump
llvm-ifs llvm-ifs
llvm-lto2 llvm-lto2
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines