This is an archive of the discontinued LLVM Phabricator instance.

Differential D105036

[mlir][llvm] Fix windows build
ClosedPublic

Authored by herhut on Jun 28 2021, 8:31 AM.

Details

Reviewers
None
Commits
rGe6450d88e280: [mlir][llvm] Fix windows build
Summary

Gate the include of alloca.h behind _WIN32 guard.

Diff Detail

Event Timeline

herhut created this revision.Jun 28 2021, 8:31 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptJun 28 2021, 8:31 AM
herhut requested review of this revision.Jun 28 2021, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2021, 8:31 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B111299: Diff 354911.Jun 28 2021, 9:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 28 2021, 9:22 AM
Closed by commit rGe6450d88e280: [mlir][llvm] Fix windows build (authored by herhut). · Explain Why
This revision was automatically updated to reflect the committed changes.
herhut added a commit: rGe6450d88e280: [mlir][llvm] Fix windows build.
mehdi_amini added a comment.Jun 28 2021, 9:28 AM

This is unusual: can you document all this please ?

(Your commit message just says « what » but not « why »)

Revision Contents

PathSize
mlir/
lib/
ExecutionEngine/
4 lines

Diff 354911

mlir/lib/ExecutionEngine/CRunnerUtils.cpp

Show All 9 Lines
// runtime. Entities in this file are meant to be retargetable, including on // runtime. Entities in this file are meant to be retargetable, including on
// targets without a C++ runtime, and must be kept C compatible. // targets without a C++ runtime, and must be kept C compatible.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/ExecutionEngine/CRunnerUtils.h" #include "mlir/ExecutionEngine/CRunnerUtils.h"
#ifndef _WIN32 #ifndef _WIN32
#include <alloca.h>
#include <sys/time.h> #include <sys/time.h>
#else
#include "malloc.h"
#endif // _WIN32 #endif // _WIN32
#include <alloca.h>
#include <cinttypes> #include <cinttypes>
#include <cstdio> #include <cstdio>
#include <string.h> #include <string.h>
#ifdef MLIR_CRUNNERUTILS_DEFINE_FUNCTIONS #ifdef MLIR_CRUNNERUTILS_DEFINE_FUNCTIONS
// Small runtime support "lib" for vector.print lowering. // Small runtime support "lib" for vector.print lowering.
// By providing elementary printing methods only, this // By providing elementary printing methods only, this
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines