This is an archive of the discontinued LLVM Phabricator instance.

Differential D105007

[NewPM] Make some sanitizer passes parameterized in the PassRegistry
ClosedPublic

Authored by bjope on Jun 28 2021, 2:26 AM.

Details

Reviewers
phosek
aeubanks
Commits
rG36d51386195e: [NewPM] Make some sanitizer passes parameterized in the PassRegistry
Summary

Refactored implementation of AddressSanitizerPass and
HWAddressSanitizerPass to use pass options similar to passes like
MemorySanitizerPass. This makes sure that there is a single mapping
from class name to pass name (needed by D108298), and options like
-debug-only and -print-after makes a bit more sense when (despite
that it is the unparameterized pass name that should be used in those
options).




A result of the above is that some pass names are removed in favor

of the parameterized versions:



    

  • "khwasan" is now "hwasan<kernel;recover>"
    • 

  • "kasan" is now "asan<kernel>"
    • 

  • "kmsan" is now "msan<kernel>"
    • 

Diff Detail
Event Timeline
bjope created this revision.Jun 28 2021, 2:26 AM
Herald added a subscriber: hiraditya.  ·  View Herald TranscriptJun 28 2021, 2:26 AM
bjope requested review of this revision.Jun 28 2021, 2:26 AM
Herald added a project: Restricted Project.  ·  View Herald TranscriptJun 28 2021, 2:26 AM
bjope mentioned this in D105006: [NewPM] Handle passes with params in -print-before/-print-after.Jun 28 2021, 2:37 AM
Harbormaster completed remote builds in B111235: Diff 354817.Jun 28 2021, 3:38 AM
phosek added inline comments.Jun 28 2021, 11:45 AM
llvm/lib/Passes/PassRegistry.def


64
Should this be kernel?
bjope updated this revision to Diff 354999.Jun 28 2021, 12:54 PM
Corrected spelling of "kernel".
bjope edited the summary of this revision. (Show Details)Jun 28 2021, 12:54 PM
bjope added inline comments.
llvm/lib/Passes/PassRegistry.def


64
Yes, thanks!
Harbormaster completed remote builds in B111355: Diff 354999.Jun 28 2021, 2:12 PM
aeubanks added a comment.Jun 28 2021, 5:14 PM
this seems like a halfway solution, we should go the full distance and make these all *_PASS_WITH_PARAMS



or if these aren't even being used in tests, just delete them
bjope updated this revision to Diff 357204.Jul 8 2021, 6:22 AM
Rebased.
Harbormaster completed remote builds in B112972: Diff 357204.Jul 8 2021, 6:59 AM
bjope updated this revision to Diff 367263.Aug 18 2021, 11:10 AM
Updated to use _PASS_WITH_PARAMS and option parsing.
Herald added a project: Restricted Project.  ·  View Herald TranscriptAug 18 2021, 11:10 AM
Herald added subscribers: cfe-commits, ormris.  ·  View Herald Transcript
bjope retitled this revision from [NewPM] Update some sanitizer pass names in the PassRegistry to [NewPM] Make some sanitizer passes parameterized in the PassRegistry.Aug 18 2021, 11:13 AM
bjope edited the summary of this revision. (Show Details)
aeubanks accepted this revision.Aug 18 2021, 11:14 AM
lgtm
This revision is now accepted and ready to land.Aug 18 2021, 11:14 AM
Harbormaster completed remote builds in B120163: Diff 367263.Aug 18 2021, 11:50 AM
This revision was landed with ongoing or failed builds.Aug 19 2021, 3:44 AM
Closed by commit rG36d51386195e: [NewPM] Make some sanitizer passes parameterized in the PassRegistry (authored by bjope).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
bjope added a commit: rG36d51386195e: [NewPM] Make some sanitizer passes parameterized in the PassRegistry.
bjope mentioned this in rGab41eef9aca3: [NewPM] Use a separate struct for ModuleMemorySanitizerPass.Sep 16 2021, 5:59 AM
bjope mentioned this in rG8f8616655c4d: [NewPM] Use a separate struct for ModuleThreadSanitizerPass.
bjope mentioned this in rGd9fc3d879e6d: [NewPM] Replace 'kasan-module' by 'asan-module<kernel>'.
Revision Contents
PathSize
llvm/
lib/
Passes/
5 lines
Diff 357204
llvm/lib/Passes/PassRegistry.def
Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
MODULE_PASS("forceattrs", ForceFunctionAttrsPass())
MODULE_PASS("forceattrs", ForceFunctionAttrsPass())

MODULE_PASS("function-import", FunctionImportPass())
MODULE_PASS("function-import", FunctionImportPass())

MODULE_PASS("function-specialization", FunctionSpecializationPass())
MODULE_PASS("function-specialization", FunctionSpecializationPass())

MODULE_PASS("globaldce", GlobalDCEPass())
MODULE_PASS("globaldce", GlobalDCEPass())

MODULE_PASS("globalopt", GlobalOptPass())
MODULE_PASS("globalopt", GlobalOptPass())

MODULE_PASS("globalsplit", GlobalSplitPass())
MODULE_PASS("globalsplit", GlobalSplitPass())

MODULE_PASS("hotcoldsplit", HotColdSplittingPass())
MODULE_PASS("hotcoldsplit", HotColdSplittingPass())

MODULE_PASS("hwasan", HWAddressSanitizerPass(false, false))
MODULE_PASS("hwasan", HWAddressSanitizerPass(false, false))

MODULE_PASS("khwasan", HWAddressSanitizerPass(true, true))
MODULE_PASS("hwasan<kernel;recover>", HWAddressSanitizerPass(true, true))

phosekUnsubmitted
Not Done
ReplyInline Actions
Should this be kernel?
phosek: Should this be `kernel`?
bjopeAuthorUnsubmitted
Done
ReplyInline Actions
Yes, thanks!
bjope: Yes, thanks!
MODULE_PASS("inferattrs", InferFunctionAttrsPass())
MODULE_PASS("inferattrs", InferFunctionAttrsPass())

MODULE_PASS("inliner-wrapper", ModuleInlinerWrapperPass())
MODULE_PASS("inliner-wrapper", ModuleInlinerWrapperPass())

MODULE_PASS("inliner-wrapper-no-mandatory-first", ModuleInlinerWrapperPass(
MODULE_PASS("inliner-wrapper-no-mandatory-first", ModuleInlinerWrapperPass(

  getInlineParams(),
  getInlineParams(),

  false))
  false))

MODULE_PASS("insert-gcov-profiling", GCOVProfilerPass())
MODULE_PASS("insert-gcov-profiling", GCOVProfilerPass())

MODULE_PASS("instrorderfile", InstrOrderFilePass())
MODULE_PASS("instrorderfile", InstrOrderFilePass())

MODULE_PASS("instrprof", InstrProfiling())
MODULE_PASS("instrprof", InstrProfiling())

▲ Show 20 Lines • Show All 245 Lines • ▼ Show 20 Lines
FUNCTION_PASS("verify<memoryssa>", MemorySSAVerifierPass())
FUNCTION_PASS("verify<memoryssa>", MemorySSAVerifierPass())

FUNCTION_PASS("verify<regions>", RegionInfoVerifierPass())
FUNCTION_PASS("verify<regions>", RegionInfoVerifierPass())

FUNCTION_PASS("verify<safepoint-ir>", SafepointIRVerifierPass())
FUNCTION_PASS("verify<safepoint-ir>", SafepointIRVerifierPass())

FUNCTION_PASS("verify<scalar-evolution>", ScalarEvolutionVerifierPass())
FUNCTION_PASS("verify<scalar-evolution>", ScalarEvolutionVerifierPass())

FUNCTION_PASS("view-cfg", CFGViewerPass())
FUNCTION_PASS("view-cfg", CFGViewerPass())

FUNCTION_PASS("view-cfg-only", CFGOnlyViewerPass())
FUNCTION_PASS("view-cfg-only", CFGOnlyViewerPass())

FUNCTION_PASS("transform-warning", WarnMissedTransformationsPass())
FUNCTION_PASS("transform-warning", WarnMissedTransformationsPass())

FUNCTION_PASS("asan", AddressSanitizerPass(false, false, false))
FUNCTION_PASS("asan", AddressSanitizerPass(false, false, false))

FUNCTION_PASS("kasan", AddressSanitizerPass(true, false, false))
FUNCTION_PASS("asan<kernel>", AddressSanitizerPass(true, false, false))

FUNCTION_PASS("msan", MemorySanitizerPass({}))
FUNCTION_PASS("msan", MemorySanitizerPass({}))

FUNCTION_PASS("kmsan", MemorySanitizerPass({0, false, /*Kernel=*/true}))

FUNCTION_PASS("tsan", ThreadSanitizerPass())
FUNCTION_PASS("tsan", ThreadSanitizerPass())

FUNCTION_PASS("memprof", MemProfilerPass())
FUNCTION_PASS("memprof", MemProfilerPass())

#undef FUNCTION_PASS
#undef FUNCTION_PASS




#ifndef FUNCTION_PASS_WITH_PARAMS
#ifndef FUNCTION_PASS_WITH_PARAMS

#define FUNCTION_PASS_WITH_PARAMS(NAME, CLASS, CREATE_PASS, PARSER, PARAMS)
#define FUNCTION_PASS_WITH_PARAMS(NAME, CLASS, CREATE_PASS, PARSER, PARAMS)

#endif
#endif

FUNCTION_PASS_WITH_PARAMS("loop-unroll",
FUNCTION_PASS_WITH_PARAMS("loop-unroll",

▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines