Depends on D104982.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
fixes inclusion issues that weren't being replicated locally
The libc++abi test diff is literally + #include <algorithm>\n, but Arcanist said the following and forced it to be treated as a binary:
Diff for 'libcxxabi/test/test_demangle.pass.cpp' with context is 5,403,317 bytes in length. Generally, source changes should not be this large. If the file is not a text file, you can mark it 'binary'. Mark this file as 'binary' and continue?
Comment Actions
LGTM but I'd like to understand the modulemap changes.
libcxx/include/module.modulemap | ||
---|---|---|
235 | Why do those export unwrap_iter? |
libcxx/include/module.modulemap | ||
---|---|---|
235 | Something to do with Clang modules not exporting them properly, which leads to linker errors regarding __rewrap_iter. I don't have a good answer. |
Why do those export unwrap_iter?