There were some issues in the patch https://reviews.llvm.org/D104198. I also forgot to address one comment. This patch addresses these.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This is a light patch that probably does not require a review and I created a patch anyway.
Would it be appropriate to get this into main using arc land if this is approved? I saw this https://reviews.llvm.org/D78867 which advises against arc land but could not find anything related to that in the main docs.
Comment Actions
I follow https://www.llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator
which says git push https://github.com/llvm/llvm-project.git HEAD:main