Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS

[LittleFox94]

Summary

This patch adds llvm-readobj and the binutils symlink for readelf to LLVM_TOOLCHAIN_TOOLS.

They are required by some (most?) autoconf-built libraries, adding these allows me to build newlib with the toolchain generated this way.

Also opened an issue for that some days ago, see https://bugs.llvm.org/show_bug.cgi?id=50698

[sbc100]

AFAICT llvm-readobj is something specific to llvm. There is no readobj in binutils or anywhere else is there?

[LittleFox94]

llvm-readobj is llvm specific, but readelf is not and llvm-readobj is llvm's implementation of readelf (hence the already existing symlink to it)

Or do you mean we shouldn't make the readobj symlink? I added it for completeness, but I didn't see a requirement for it

Am 28. Juni 2021 19:03:46 MESZ schrieb Sam Clegg via Phabricator <[e-mail]>:

sbc100 added a comment.

AFAICT llvm-readobj is something specific to llvm. There is no
readobj in binutils or anywhere else is there?

Repository:

rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

https://reviews.llvm.org/D104957/new/

https://reviews.llvm.org/D104957

[sbc100]

In D104957#2844681, @LittleFox94 wrote:

llvm-readobj is llvm specific, but readelf is not and llvm-readobj is llvm's implementation of readelf (hence the already existing symlink to it)

Or do you mean we shouldn't make the readobj symlink? I added it for completeness, but I didn't see a requirement for it

Yes it seems perhaps unnecessary (and maybe confusing?) to include that symlink.

Am 28. Juni 2021 19:03:46 MESZ schrieb Sam Clegg via Phabricator <[e-mail]>:

sbc100 added a comment.

AFAICT llvm-readobj is something specific to llvm. There is no
readobj in binutils or anywhere else is there?

Repository:

rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

https://reviews.llvm.org/D104957/new/

https://reviews.llvm.org/D104957

[LittleFox94]

Removed the symlink to readobj since it's not required and might be confusing

[LittleFox94]

Slight ping

I removed the readobj symlink but am not sure if you were notified of that ^^'

[LittleFox94]

hey @sbc100, do you have time to look at this again? Would be great to have this upstreamed :)

[LittleFox94]

Thank you for looking at it again and approving it, @sbc100 :)

Sorry to have to bother you again, but could you maybe also commit it? I cannot do that myself, sadly ._.
Also, is this something I should write in the summary already, in the future?

Author for the commit would be Mara Sophie Grosch <[e-mail]>

Thank you

[xgupta]

In D104957#2895687, @LittleFox94 wrote:

Thank you for looking at it again and approving it, @sbc100 :)

Sorry to have to bother you again, but could you maybe also commit it? I cannot do that myself, sadly ._.
Also, is this something I should write in the summary already, in the future?

Author for the commit would be Mara Sophie Grosch <[e-mail]>

Thank you

@LittleFox94 if you want to continue contributing, you may ask for commit access, bar is quite low in LLVM community.
Please follow:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

[LittleFox94]

@sbc100 thank you for committing this :)

@xgupta thank you for mentioning I might ask for commit access, I did and was accepted yesterday

Wanted to use this commit as my test commit, but now it's already done (which is good, thanks) ^^

[xgupta]

In D104957#2899452, @LittleFox94 wrote:

@xgupta thank you for mentioning I might ask for commit access, I did and was accepted yesterday

Awesome! just remember with great power comes greats responsibility :)

llvm/cmake/modules/AddLLVM.cmake

set (LLVM_TOOLCHAIN_TOOLS
     llvm-cov
     llvm-cxxfilt
     llvm-ranlib
     llvm-lib
     llvm-nm
     llvm-objcopy
     llvm-objdump
     llvm-rc
+    llvm-readobj
     llvm-size
     llvm-strings
     llvm-strip
     llvm-profdata
     llvm-symbolizer
     # symlink version of some of above tools that are enabled by
     # LLVM_INSTALL_BINUTILS_SYMLINKS.
     addr2line
     ar
     c++filt
     ranlib
     nm
     objcopy
     objdump
+    readobj
+    readelf
     size
     strings
     strip
     )
 endif()
 
 macro(add_llvm_tool name)
   if( NOT LLVM_BUILD_TOOLS )