Page MenuHomePhabricator

LittleFox94 (Mara Sophie Grosch)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2020, 10:34 AM (82 w, 2 d)

Recent Activity

Sep 12 2021

LittleFox94 added a comment to D109653: Fix some definitions on AVR target.

This is committed by now, but I would still love to know if this would have been ok to just commit (and have post-commit review) :)

Sep 12 2021, 4:28 AM · Restricted Project
LittleFox94 committed rG339c73404224: [Clang][AVR] Fix definitions on AVR target (authored by LittleFox94).
[Clang][AVR] Fix definitions on AVR target
Sep 12 2021, 2:01 AM
LittleFox94 closed D109653: Fix some definitions on AVR target.
Sep 12 2021, 2:01 AM · Restricted Project

Sep 11 2021

LittleFox94 added a comment to D109653: Fix some definitions on AVR target.

I guess this would have qualified for post-commit review, but since this would have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.

Sep 11 2021, 3:07 PM · Restricted Project
LittleFox94 requested review of D109653: Fix some definitions on AVR target.
Sep 11 2021, 3:06 PM · Restricted Project

Jul 23 2021

LittleFox94 added a comment to D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

@sbc100 thank you for committing this :)

Jul 23 2021, 2:13 AM · Restricted Project

Jul 22 2021

LittleFox94 added a comment to D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

Thank you for looking at it again and approving it, @sbc100 :)

Jul 22 2021, 12:38 AM · Restricted Project

Jul 21 2021

LittleFox94 added a comment to D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

hey @sbc100, do you have time to look at this again? Would be great to have this upstreamed :)

Jul 21 2021, 5:12 AM · Restricted Project

Jul 3 2021

LittleFox94 added a comment to D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

Slight ping

Jul 3 2021, 11:01 AM · Restricted Project

Jun 28 2021

LittleFox94 updated the diff for D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

Removed the symlink to readobj since it's not required and might be confusing

Jun 28 2021, 1:31 PM · Restricted Project
LittleFox94 added a comment to D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.

llvm-readobj is llvm specific, but readelf is not and llvm-readobj is llvm's implementation of readelf (hence the already existing symlink to it)

Jun 28 2021, 10:08 AM · Restricted Project

Jun 27 2021

LittleFox94 added a comment to D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Got three buildbot failure mails with only me in the blamelist (thats a first), but they don't look like they are related to the change, but rather the build server having killed the compiler?

Jun 27 2021, 5:47 AM · Restricted Project

Jun 26 2021

LittleFox94 added a comment to D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Thanks for your review :)

Jun 26 2021, 7:25 AM · Restricted Project

Jun 25 2021

LittleFox94 edited reviewers for D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built, added: sgraenitz; removed: chandlerc.

Change reviewer to author of file - might be the better option than code_owners

Jun 25 2021, 4:53 PM · Restricted Project
LittleFox94 added a reviewer for D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS: llvm-commits.
Jun 25 2021, 4:43 PM · Restricted Project
LittleFox94 requested review of D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS.
Jun 25 2021, 4:17 PM · Restricted Project

Apr 22 2021

LittleFox94 added a comment to D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Ping

Apr 22 2021, 5:51 AM · Restricted Project

Apr 11 2021

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Removed the unnecessary check as requested.

Apr 11 2021, 4:24 PM · Restricted Project
LittleFox94 updated the diff for D79888: libc++: move checks for newlib to actually work.

Removed an unnecessary check as requested in review

Apr 11 2021, 4:23 PM · Restricted Project

Apr 7 2021

LittleFox94 added a reviewer for D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built: chandlerc.

Adding @chandlerc as a reviewer since first entry in CODE_OWNERS for CMake ^^'

Apr 7 2021, 9:34 PM · Restricted Project
LittleFox94 updated the diff for D79888: libc++: move checks for newlib to actually work.
Apr 7 2021, 9:06 PM · Restricted Project
LittleFox94 updated the diff for D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

formatting was bad and somehow differential didn't show the endif() - added a trailing newline for that

Apr 7 2021, 6:41 PM · Restricted Project
LittleFox94 requested review of D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.
Apr 7 2021, 6:38 PM · Restricted Project

Sep 14 2020

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Is this review still relevant? If not, let's abandon it to clear up the review queue.

Sep 14 2020, 5:16 PM · Restricted Project

May 13 2020

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

We could lift the two macros that depend on _NEWLIB_VERSION into the headers that use them.
Then we'll avoid the include in config.

May 13 2020, 1:03 PM · Restricted Project
LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

I am slightly concerned that this also introduces a bunch of declarations in __config, which is the most included file of the library. That would also be the first time we include unistd.h in the libc++ headers (as opposed to the sources used to build the dylib). That might not be an issue, but it's something to keep in mind.

Another way would be to include _newlib_version.h if it exists, would that be better? Would then be a newlib specific patch.

May 13 2020, 12:31 PM · Restricted Project
LittleFox94 created D79888: libc++: move checks for newlib to actually work.
May 13 2020, 10:50 AM · Restricted Project
LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Since this include was deleted as "dead code" before, I added a comment why it is not dead

May 13 2020, 10:50 AM · Restricted Project

May 12 2020

LittleFox94 added inline comments to D79784: [libc++] Adjust how we guard the inclusion of unistd.h.
May 12 2020, 8:01 AM · Restricted Project

May 7 2020

LittleFox94 added a comment to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Cannot commit myself

May 7 2020, 10:14 AM · Restricted Project, Restricted Project

May 4 2020

LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Also fix duplicated check in filesystem/operations.cpp

May 4 2020, 3:37 PM · Restricted Project, Restricted Project
LittleFox94 added inline comments to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.
May 4 2020, 2:32 PM · Restricted Project, Restricted Project
LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Do not include unistd.h on _WIN32, re-add __APPLE__ check and change _POSIX_TIMER check to check for > 0

May 4 2020, 2:32 PM · Restricted Project, Restricted Project
LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Included unistd.h and removed the check for __APPLE__, since _POSIX_TIMERS should work there, too

May 4 2020, 8:32 AM · Restricted Project, Restricted Project
LittleFox94 added a comment to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

LGTM generally speaking, but is this triggered by a specific failure you ran into? If so, on what configuration? We should have a way to test this change.

May 4 2020, 8:32 AM · Restricted Project, Restricted Project

May 3 2020

LittleFox94 created D79305: chrono: check _POSIX_TIMERS before using clock_gettime.
May 3 2020, 11:09 AM · Restricted Project, Restricted Project