This is an archive of the discontinued LLVM Phabricator instance.

[Coroutines] Remove all legacy test command
ClosedPublic

Authored by lxfind on Jun 24 2021, 9:42 PM.

Details

Summary

With new pm becomes the default, the old-style test command becomes exactly the same as the new test command, i.e. the two commands are now redundant.
We should just delete the old command. (unless someone wants to add enable-new-pm=0 to all old commands.

Diff Detail

Event Timeline

lxfind created this revision.Jun 24 2021, 9:42 PM
lxfind requested review of this revision.Jun 24 2021, 9:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2021, 9:42 PM

Thanks for working on this!
If the two commands behaves the same, I prefer the old styles since it looks simpler.

Thanks for working on this!
If the two commands behaves the same, I prefer the old styles since it looks simpler.

I believe the plan is to have all tests to be in -passes style with new pm (I.e -passes is the preferred style)

yes, at some point when we've deprecated the legacy PM for the optimziation pipeline I will switch all tests to use -passes=

aeubanks accepted this revision.Jun 25 2021, 9:39 AM
This revision is now accepted and ready to land.Jun 25 2021, 9:39 AM
This revision was landed with ongoing or failed builds.Jun 25 2021, 9:47 AM
This revision was automatically updated to reflect the committed changes.