[NFC] Remove unreferenced function ResolveIPV4HostName

[teemperor]

(Nit: this is from the Linux manpage but this code is only compiled on Darwin).

[jankratochvil]

In D104856#2838515, @teemperor wrote:

(Nit: this is from the Linux manpage but this code is only compiled on Darwin).

Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this function was removed by Re-landing IPv6 support for LLDB Host.

lldb/tools/debugserver/source/RNBSocket.cpp

32–33

`in

[teemperor]

In D104856#2838526, @jankratochvil wrote:

In D104856#2838515, @teemperor wrote:

(Nit: this is from the Linux manpage but this code is only compiled on Darwin).

Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this function was removed by Re-landing IPv6 support for LLDB Host.

The file is part of debugserver which is Darwin exclusive and is also only compiled/used when you're on Darwin. It's also kind of its own thing: it isn't using LLVM libraries such as ADT and we usually leave it out of larger refactorings because it's kind of in "maintenance-only" mode IIRC.

Anyway, this patch is probably fine but I added Jason as a reviewer because he knows the debugserver best.

[jankratochvil]

In D104856#2838571, @teemperor wrote:

The file is part of debugserver which is Darwin exclusive and is also only compiled/used when you're on Darwin. It's also kind of its own thing: it isn't using LLVM libraries such as ADT and we usually leave it out of larger refactorings because it's kind of in "maintenance-only" mode IIRC.

I still do not understand what code can use this function on OSX and on OSX I build with -DLLDB_USE_SYSTEM_DEBUGSERVER=ON which probably won't build the new lldb-server then.

Besides that IMO @serge-sans-paille may not need to patch it when it is OSX-only function.

lldb/tools/debugserver/source/RNBSocket.cpp

32–33

Here the prototype does not permit IPv6.

32–33

This is redundant with getaddrinfo.

32–33

This is redundant with getaddrinfo.

32–33

Here it should use ((sockaddr_in *)addr->ai_addr)->sin_addr after verifying it is an IPv4 address - instead of the inet_ntoa+inet_pton calls.
Also it should iterate all the addresses by addr->ai_next (which is not possible with the ResolveIPV4HostName function prototype).

[teemperor]

In D104856#2838600, @jankratochvil wrote:

In D104856#2838571, @teemperor wrote:

The file is part of debugserver which is Darwin exclusive and is also only compiled/used when you're on Darwin. It's also kind of its own thing: it isn't using LLVM libraries such as ADT and we usually leave it out of larger refactorings because it's kind of in "maintenance-only" mode IIRC.

I still do not understand what code can use this function on OSX and on OSX I build with -DLLDB_USE_SYSTEM_DEBUGSERVER=ON which probably won't build the new lldb-server then.

We build both lldb-server and debugserver on Darwin but we're only using debugserver by default there. And LLDB_USE_SYSTEM_DEBUGSERVER just makes us copy the (codesigned) system debugserver into our build directory instead of building our own (but we still build lldb-server with that option IIRC).

[jankratochvil]

lldb/tools/debugserver/source/RNBSocket.cpp

32–33

Here it should use AI_PASSIVE instead.

[jankratochvil]

On OSX with -DLLDB_USE_SYSTEM_DEBUGSERVER=OFF I have built:
-rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver
It uses lldb/tools/debugserver/source/RNBSocket.cpp (if I mess up the source file it does not build). The build does not need this ResolveIPV4HostName function.
So unless there is some more OSX magic the function can be removed.

[teemperor]

In D104856#2839256, @jankratochvil wrote:

On OSX with -DLLDB_USE_SYSTEM_DEBUGSERVER=OFF I have built:
-rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver
It uses lldb/tools/debugserver/source/RNBSocket.cpp (if I mess up the source file it does not build). The build does not need this ResolveIPV4HostName function.
So unless there is some more OSX magic the function can be removed.

Sorry, I thought you meant with "this function" gethostbyname not ResolveIPV4HostName. You're right, this is indeed unused and it's also used in our downstream repo I think, so let's get rid of it. Good catch!

[serge-sans-paille]

Just remove the function

[serge-sans-paille]

What a simpler patch!

[teemperor]

LGTM

lldb/tools/debugserver/source/RNBSocket.cpp

 #include <termios.h>
 #include <vector>
 
 #include "lldb/Host/SocketAddress.h"
 
 #ifdef WITH_LOCKDOWN
 #include "lockdown.h"
 #endif
 
-/* Once we have a RNBSocket object with a port # specified,
-   this function is called to wait for an incoming connection.
-   This function blocks while waiting for that connection.  */
-
-bool ResolveIPV4HostName(const char *hostname, in_addr_t &addr) {
-  if (hostname == NULL || hostname[0] == '\0' ||
-      strcmp(hostname, "localhost") == 0 ||
-      strcmp(hostname, "127.0.0.1") == 0) {
-    addr = htonl(INADDR_LOOPBACK);
-    return true;
-  } else if (strcmp(hostname, "*") == 0) {
-    addr = htonl(INADDR_ANY);
-    return true;
-  } else {
-    // See if an IP address was specified as numbers
-    int inet_pton_result = ::inet_pton(AF_INET, hostname, &addr);
-
-    if (inet_pton_result == 1)
-      return true;
-
-    struct hostent *host_entry = gethostbyname(hostname);
-    if (host_entry) {
-      std::string ip_str(
-          ::inet_ntoa(*(struct in_addr *)*host_entry->h_addr_list));
-      inet_pton_result = ::inet_pton(AF_INET, ip_str.c_str(), &addr);
-      if (inet_pton_result == 1)
-        return true;
-    }
-  }
-  return false;
-}
-
 rnb_err_t RNBSocket::Listen(const char *listen_host, uint16_t port,
                             PortBoundCallback callback,
                             const void *callback_baton) {
   // DNBLogThreadedIf(LOG_RNB_COMM, "%8u RNBSocket::%s called",
   // (uint32_t)m_timer.ElapsedMicroSeconds(true), __FUNCTION__);
   // Disconnect without saving errno
   Disconnect(false);
 
   DNBError err;