Page MenuHomePhabricator

[runtimes] Simplify how we specify XFAIL & friends based on the triple
ClosedPublic

Authored by ldionne on Jun 22 2021, 2:00 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rGc360553c15a8: [runtimes] Simplify how we specify XFAIL & friends based on the triple
Summary

Now that Lit supports regular expressions inside XFAIL * friends, it is
much easier to write Lit annotations based on the triple.

Diff Detail

Event Timeline

ldionne created this revision.Jun 22 2021, 2:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2021, 2:00 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Jun 22 2021, 2:00 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 22 2021, 2:00 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 353980.Jun 23 2021, 7:55 AM

Temporarily include the Lit patch so CI may succeed.

Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2021, 7:55 AM
ldionne updated this revision to Diff 355552.Wed, Jun 30, 7:55 AM

Rebase onto main, now that the Lit change has landed.

ldionne updated this revision to Diff 355875.Thu, Jul 1, 7:28 AM

Fix a few incorrect XFAILs

ldionne accepted this revision.Thu, Jul 1, 10:56 AM

The only failure is a flaky test on Windows.

I also validated that this didn't change which tests get run by looking at the logs for all CI configurations and confirming that the PASS, FAIL, UNSUPPORTED, etc. were the same as those on a main build. So it looks like I did not mess up any annotation and disable tests by accident, at least in the configurations that we have CI for.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 1, 11:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.