Page MenuHomePhabricator

[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options
ClosedPublic

Authored by mibintc on Jun 22 2021, 11:10 AM.

Diff Detail

Event Timeline

mibintc created this revision.Jun 22 2021, 11:10 AM
mibintc requested review of this revision.Jun 22 2021, 11:10 AM
aaron.ballman accepted this revision.Jun 23 2021, 9:40 AM

LGTM, but you should land this only after we accept D100118 because it's only needed for that functionality.

This revision is now accepted and ready to land.Jun 23 2021, 9:40 AM
mibintc reopened this revision.Mon, Jun 28, 12:08 PM

buildbot fails in lldb, will submit updates

This revision is now accepted and ready to land.Mon, Jun 28, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Jun 28, 12:10 PM
mibintc reopened this revision.Mon, Jun 28, 12:48 PM

More buildbot failures

This revision is now accepted and ready to land.Mon, Jun 28, 12:48 PM