This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Add --no-print-imm-hex to the command guide
ClosedPublic

Authored by gbreynoo on Jun 22 2021, 8:11 AM.

Details

Summary

The option --no-print-imm-hex was not included in the command guide for llvm-objdump but appears in the help text. This commit adds it to the command guide.

Diff Detail

Event Timeline

gbreynoo requested review of this revision.Jun 22 2021, 8:11 AM
gbreynoo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2021, 8:11 AM
MaskRay added a comment.EditedJun 22 2021, 9:19 AM

I am on the fence. For certain boolean options, I think it is usually sufficient to document just the non-default option (e.g. --foo), no need for the default option (e.g. --no-foo).

I think these are nice to document since sometimes it's useful to be able to negate the previous passed flag, especially if you're doing it in some sort of script, but I have to admit I've never had that case with llvm-objdump

jhenderson accepted this revision.Jun 23 2021, 12:10 AM

I am on the fence. For certain boolean options, I think it is usually sufficient to document just the non-default option (e.g. --foo), no need for the default option (e.g. --no-foo).

I don't think it is necessarily obvious which options can be negated. Certainly, for some options in some tools, there is no --no-* equivalent.

LGTM.

This revision is now accepted and ready to land.Jun 23 2021, 12:10 AM