This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add test for min/max
ClosedPublic

Authored by Rin on Jun 17 2021, 4:48 AM.

Details

Summary

This patch adds a test for min/max.

Diff Detail

Event Timeline

Rin created this revision.Jun 17 2021, 4:48 AM
Rin requested review of this revision.Jun 17 2021, 4:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2021, 4:48 AM
Rin edited the summary of this revision. (Show Details)Jun 17 2021, 4:48 AM
Rin added reviewers: dmgreen, SjoerdMeijer.
Rin updated this revision to Diff 352698.Jun 17 2021, 6:25 AM

Remove v2i64 test case.

It would be good to keep the v2i64 case I think, it is very similar to v1i64.

Rin added a comment.EditedJul 1 2021, 1:04 AM

It would be good to keep the v2i64 case I think, it is very similar to v1i64.

I'll re add it.

Rin updated this revision to Diff 355823.Jul 1 2021, 3:50 AM

Add v2i64 testcase

It's probably good to add them for all the types, even if just for consistency. So for umax/smax/smin too.

dmgreen accepted this revision.Jul 1 2021, 4:09 AM

Otherwise sounds good to me.

This revision is now accepted and ready to land.Jul 1 2021, 4:09 AM
Rin added a comment.Jul 1 2021, 4:11 AM

It's probably good to add them for all the types, even if just for consistency. So for umax/smax/smin too.

Oh, yeah, sorry, my bad. I'll add them right away.

Rin updated this revision to Diff 355834.Jul 1 2021, 4:26 AM

Fix tests

This revision was landed with ongoing or failed builds.Jul 1 2021, 5:23 AM
This revision was automatically updated to reflect the committed changes.