This is an archive of the discontinued LLVM Phabricator instance.

[mlir-reduce] Improve diagnostic message and clean build dependency
ClosedPublic

Authored by Chia-hungDuan on Jun 17 2021, 2:06 AM.

Diff Detail

Event Timeline

Chia-hungDuan created this revision.Jun 17 2021, 2:06 AM
Chia-hungDuan requested review of this revision.Jun 17 2021, 2:06 AM
rriddle accepted this revision.Jun 17 2021, 2:13 AM

Looks good, thanks!

mlir/lib/Reducer/ReductionTreePass.cpp
87

nit: diagnostics should start with a lower case.

157–159

?

mlir/lib/Tools/mlir-reduce/MlirReduceMain.cpp
61–62

Should we just register all of the passes? Is there a reason to do just the one?

This revision is now accepted and ready to land.Jun 17 2021, 2:13 AM
Chia-hungDuan marked 3 inline comments as done.Jun 23 2021, 12:37 AM
Chia-hungDuan updated this revision to Diff 353863.EditedJun 23 2021, 12:39 AM

Addressed review comments, added a OptionCategory for mlir-reduce and hid the unrelated options
Now only mlir passes will be shown.

This revision was landed with ongoing or failed builds.Jul 4 2021, 7:41 PM
This revision was automatically updated to reflect the committed changes.