Improve error reporting on pass registration collision (NFC) # Please enter the commit message for your changes. Lines starting

[rriddle]

LGTM (but I think you already landed this)

[mehdi_amini]

In D104430#2823541, @rriddle wrote:

LGTM (but I think you already landed this)

I haven't actually :)

[rriddle]

In D104430#2823621, @mehdi_amini wrote:

In D104430#2823541, @rriddle wrote:

LGTM (but I think you already landed this)

I haven't actually :)

Right (I was thinking of https://github.com/llvm/llvm-project/commit/a6e8ed77762e2c973dbc60d6436d64a25f9f1bee#diff-e0acb49d6ec4a97460a1af5fe8f80abc39f04d172d6c9a08c33da1209115cd4b)

mlir/lib/Pass/PassRegistry.cpp

void mlir::registerPass(StringRef arg, StringRef description,
                         const PassAllocatorFunction &function) {
   PassInfo passInfo(arg, description, function);
   passRegistry->try_emplace(arg, passInfo);
 
   // Verify that the registered pass has the same ID as any registered to this
   // arg before it.
   TypeID entryTypeID = function()->getTypeID();
   auto it = passRegistryTypeIDs->try_emplace(arg, entryTypeID).first;
-  if (it->second != entryTypeID) {
-    llvm_unreachable("pass allocator creates a different pass than previously "
-                     "registered");
-  }
+  if (it->second != entryTypeID)
+    llvm::report_fatal_error(
+        "pass allocator creates a different pass than previously "
+        "registered for pass " +
+        arg);
 }
 
 void mlir::registerPass(const PassAllocatorFunction &function) {
   std::unique_ptr<Pass> pass = function();
   StringRef arg = pass->getArgument();
   if (arg.empty())
     llvm::report_fatal_error(
         "Trying to register a pass that does not override `getArgument()`: " +