This is an archive of the discontinued LLVM Phabricator instance.

Differential D104368

[mlir] NFC - Drop newline form BlockArgument printing.
ClosedPublic

Authored by nicolasvasilache on Jun 16 2021, 4:15 AM.

Details

Reviewers
rriddle
ftynse
jpienaar
Commits
rGa1678987d982: [mlir] NFC - Drop newline form BlockArgument printing.

Diff Detail

Event Timeline

nicolasvasilache created this revision.Jun 16 2021, 4:15 AM
Herald added subscribers: dcaballe, cota, teijeong and 15 others. · View Herald TranscriptJun 16 2021, 4:15 AM
nicolasvasilache requested review of this revision.Jun 16 2021, 4:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2021, 4:15 AM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
nicolasvasilache mentioned this in D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).Jun 16 2021, 4:16 AM

Discussed as part of the review of https://reviews.llvm.org/D104110

jpienaar accepted this revision.Jun 16 2021, 5:31 AM
This revision is now accepted and ready to land.Jun 16 2021, 5:31 AM
This revision was landed with ongoing or failed builds.Jun 16 2021, 6:29 AM
Closed by commit rGa1678987d982: [mlir] NFC - Drop newline form BlockArgument printing. (authored by nicolasvasilache). · Explain Why
This revision was automatically updated to reflect the committed changes.
nicolasvasilache added a commit: rGa1678987d982: [mlir] NFC - Drop newline form BlockArgument printing..
Harbormaster completed remote builds in B109486: Diff 352392.Jun 16 2021, 9:43 AM

Revision Contents

PathSize
mlir/
lib/
IR/
4 lines

Diff 352417

mlir/lib/IR/AsmPrinter.cpp

Show First 20 Lines • Show All 2,736 Lines • ▼ Show 20 Lines
} }
void Value::print(raw_ostream &os) { void Value::print(raw_ostream &os) {
if (auto *op = getDefiningOp()) if (auto *op = getDefiningOp())
return op->print(os); return op->print(os);
// TODO: Improve BlockArgument print'ing. // TODO: Improve BlockArgument print'ing.
BlockArgument arg = this->cast<BlockArgument>(); BlockArgument arg = this->cast<BlockArgument>();
os << "<block argument> of type '" << arg.getType() os << "<block argument> of type '" << arg.getType()
<< "' at index: " << arg.getArgNumber() << '\n'; << "' at index: " << arg.getArgNumber();
} }
void Value::print(raw_ostream &os, AsmState &state) { void Value::print(raw_ostream &os, AsmState &state) {
if (auto *op = getDefiningOp()) if (auto *op = getDefiningOp())
return op->print(os, state); return op->print(os, state);
// TODO: Improve BlockArgument print'ing. // TODO: Improve BlockArgument print'ing.
BlockArgument arg = this->cast<BlockArgument>(); BlockArgument arg = this->cast<BlockArgument>();
os << "<block argument> of type '" << arg.getType() os << "<block argument> of type '" << arg.getType()
<< "' at index: " << arg.getArgNumber() << '\n'; << "' at index: " << arg.getArgNumber();
} }
void Value::dump() { void Value::dump() {
print(llvm::errs()); print(llvm::errs());
llvm::errs() << "\n"; llvm::errs() << "\n";
} }
void Value::printAsOperand(raw_ostream &os, AsmState &state) { void Value::printAsOperand(raw_ostream &os, AsmState &state) {
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines