Page MenuHomePhabricator

Alters a lit test to simplify and avoid a buildbot error
AbandonedPublic

Authored by feg208 on Jun 14 2021, 10:18 AM.

Diff Detail

Event Timeline

feg208 requested review of this revision.Jun 14 2021, 10:18 AM
feg208 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 10:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Could you split this into two diffs? Or are those two changes in any way related?

Could you split this into two diffs? Or are those two changes in any way related?

I can if you'd like. They are related in the sense that the dead code yielded warnings in the buildbot logs that necessitated this change set.

feg208 updated this revision to Diff 351982.Jun 14 2021, 1:27 PM

Looks like the dead code is removed in main

feg208 retitled this revision from Removes an unused variable and alters a lit test to simplify and avoid a buildbot error to Alters a lit test to simplify and avoid a buildbot error.Jun 14 2021, 1:30 PM
vitalybuka accepted this revision.Jun 14 2021, 9:24 PM
This revision is now accepted and ready to land.Jun 14 2021, 9:24 PM

I don’t have commit rights currently. Could I get someone to land this on my behalf?

I put up a separate commit that just removes the test. I think this would resolve the builder issues but I don't think its worth even trying. We should abandon this (I think)

feg208 abandoned this revision.Jun 15 2021, 5:04 PM