This is an archive of the discontinued LLVM Phabricator instance.

Alters a lit test to simplify and avoid a buildbot error
AbandonedPublic

Authored by feg208 on Jun 14 2021, 10:18 AM.

Download Raw Diff

Details

Reviewers

HazardyKnusperkeks
Bigcheese
vitalybuka

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

feg208 requested review of this revision.Jun 14 2021, 10:18 AM

feg208 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 10:18 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B109133: Diff 351913.Jun 14 2021, 11:28 AM

Could you split this into two diffs? Or are those two changes in any way related?

In D104242#2817815, @HazardyKnusperkeks wrote:

Could you split this into two diffs? Or are those two changes in any way related?

I can if you'd like. They are related in the sense that the dead code yielded warnings in the buildbot logs that necessitated this change set.

Looks like the dead code is removed in main

feg208 retitled this revision from Removes an unused variable and alters a lit test to simplify and avoid a buildbot error to Alters a lit test to simplify and avoid a buildbot error.Jun 14 2021, 1:30 PM

Harbormaster completed remote builds in B109187: Diff 351982.Jun 14 2021, 2:32 PM

feg208 added a reviewer: vitalybuka.Jun 14 2021, 8:33 PM

vitalybuka accepted this revision.Jun 14 2021, 9:24 PM

This revision is now accepted and ready to land.Jun 14 2021, 9:24 PM

I don’t have commit rights currently. Could I get someone to land this on my behalf?

I put up a separate commit that just removes the test. I think this would resolve the builder issues but I don't think its worth even trying. We should abandon this (I think)

feg208 abandoned this revision.Jun 15 2021, 5:04 PM

Revision Contents

Path

Size

clang/

test/

Format/

struct-array-initializer.cpp

8 lines

Diff 351982

clang/test/Format/struct-array-initializer.cpp

	// RUN: grep -Ev "// *[A-Z-]+:" %s \			// RUN: clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Right}" %s \| FileCheck -strict-whitespace -check-prefix=CHECK1 %s
	// RUN: \| clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Right}" %s \			// RUN: clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \| FileCheck -strict-whitespace -check-prefix=CHECK2 %s
	// RUN: \| FileCheck -strict-whitespace -check-prefix=CHECK1 %s
	// RUN: grep -Ev "// *[A-Z-]+:" %s \
	// RUN: \| clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \
	// RUN: \| FileCheck -strict-whitespace -check-prefix=CHECK2 %s
	struct test {			struct test {
	int a;			int a;
	int b;			int b;
	const char *c;			const char *c;
	};			};

	struct toast {			struct toast {
	int a;			int a;
	▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines