User Details
- User Since
- Apr 25 2021, 7:55 AM (62 w, 2 d)
Mar 6 2022
I have been watching the issues pile up around this but work has prevented me from focusing on them. This seems like a reasonable compromise but the note of disabling this feature is also reasonable. Given where it had to be placed in the formatting flow I suspect it will be challenging to resolve most of the troublesome corner cases. I did investigate one bug I picked up but ran into the problems you described earlier and was going down the same compromise path.
Sep 28 2021
Absolutely in agreement
By one other bug I mean an entirely separate bug that I will handle in a separate PR. Sorry if that was confusing.
So I added in the second case but commented it out as it gets misformatted. However it doesn't assert which was the alarming outcome. I have one other bug to clean up here and I am going to open a bug to fix the line breaking after initial { in certain cases since the code there needs to be revisited. I am doing formatting in the info gathering loop where really I should add all that in the back end. But thats a bigger change that I'd like to do outside of mitigating this users crash.
Gets rid of the crash for the second added case
Sep 27 2021
Sep 26 2021
Sep 25 2021
Sep 24 2021
I am. I'll jump on this over the weekend. Sorry been a bit buried in my day job
Jun 28 2021
I have a few outstanding questions
Addresses some review comments
Jun 21 2021
I'd just wanted to follow up and see if, minimally, my changes addressed the concerns raised or if you think there is further work here?
Jun 15 2021
If I could get someone to land this commit on my behalf I'd be obliged. I am working on the getting commit rights since that seems to be a pretty significant impediment to developing in llvm land but as of now I can't land this myself.
I put up a separate commit that just removes the test. I think this would resolve the builder issues but I don't think its worth even trying. We should abandon this (I think)
I think, at this point, the sensible thing to do is to pull the test. As @MyDeveloperDay points out it isn't really adding any value above and beyond the unit tests. If it were non-determinism in the change itself the unit tests would catch it. They test the same formatting and test for non-determinism explicitly. Yet they've never failed. And there are quite a few of them.
Jun 14 2021
I don’t have commit rights currently. Could I get someone to land this on my behalf?
Looks like the dead code is removed in main
Forgot the clang-tidy checks
Clang-tidy checks cleaned up and test fixes
Ok. I am going to see if I can replicate the issue locally. Otherwise the easiest path (imho) is to pull the lit test that is failing. It isn't telling us anything we don't already know from the unit tests in any case. But maybe its something odd like the spacing or the single '-' in the option flags on FileCheck
Jun 13 2021
Added command line print
This is not yet complete. I missed step 4a. "4a. If we crash, we generate the reproducer and print the dsymutil invocation to replay the reproducer." It currently doesn't print the command line
Fixes the broken tests
Jun 12 2021
Rolled up review comments
I think this covers the comments
Jun 10 2021
If I can get someone to submit this on my behalf I think we can call it a day.
Jun 9 2021
All the review comments are addressed
Rolls up the remaining review comments
addressed the remaining review comment
Regenerated the mangled ClangFormatStyle.rst file
Ick. Missed a semi colon in the test
Fixes the busted test
Got some changes. The failing test is an open issue
Gets some of the formatting issues. Still chasing a test issue.
Jun 8 2021
Fixes from clang-tidy checks
This alters the array alignment to allow for left alignment
Jun 7 2021
Ok. Given @HazardyKnusperkeks comment I'll make the default be left alignment and update the tests accordingly
Gets some review comments
I rolled up all the comments save one where I just have an outstanding question and then I'll roll that up as well
Jun 3 2021
Had some invalid code in the lit test
Rebased against main
Got both of these
Grabs up some review comments and adds lit test
Jun 2 2021
Adds a simple lit test for some sanity checks
one remaining
Missed a request
Captured review comments
I rolled up the suggested changes.
oops left some debugging messages in
I am wondering if I could get someone to look at this? I think I have addressed the review comments but I'd be happy to fix anything I missed
I am of the view that this is complete. Or at a minimum all the tests that have
been requested pass and I would be surprised if there were gross errors or other
major things I have missed
May 27 2021
Rolls up review comments
I picked up most of these. One of the tests is already covered (I think) maybe I am misunderstanding
May 26 2021
Still need to fix and add the tests I said I would but the comment tests are added
May 25 2021
Addresses review comments
The tests still need to be added
May 24 2021
Broke a regression test
I think I addressed all the comments? If so I can't push the changes into the repo. Could you? Assuming there aren't outstanding concerns of course.
Addresses some review comments
clang-tidy and clang-format changes
May 23 2021
Fixes/adds a test that yielded a seg fault and quiets some clang-tidy checks
May 22 2021
Adds some tests and fixes a broken test
Forgot to alter the documentation to reflect right justified column alignment
This reworks substantially this commit. I recognize there are lacking/broken
tests but I just would like to ensure that the general direction doesn't
seem likely to end in tears
May 21 2021
May 8 2021
I still need to handle the 20 character case appropriately
May 7 2021
Missed a request in the release notes
Oops missed a request
Added more tests and addressed review comments
I think I have all the tests and requested review comments rolled up
May 6 2021
I have a few outstanding questions about additional testing
To answer the question of why I think this is different then other alignment options....It seems to me that each alignment option emphasizes a specific thing, be it macros, bitfields, or (maybe closer in spirit) more simple declarations and assignments. I think this case is unique and not currently addressed by any of the existing alignment mechanisms.
This addresses most of the review comments. There remain a few tests to add
May 4 2021
May 1 2021
clang-format misses
Apr 29 2021
Cleans up clang-tidy/format issues and some minor branch pecadillos
Apr 28 2021
Forgot to remove raise(SIGSEGV)
This alters the prior commit by incorporating the Reproducer for the purpose of persisting the files on crash
Apr 27 2021
Missing more clang-tidy checks
Apr 26 2021
Fixed clang-tidy warnings