This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add ExpOp to Complex dialect.
ClosedPublic

Authored by akuegel on Jun 11 2021, 4:46 AM.

Details

Summary

Also add a conversion pattern from Complex to Standard/Math dialect.

Diff Detail

Event Timeline

akuegel created this revision.Jun 11 2021, 4:46 AM
akuegel requested review of this revision.Jun 11 2021, 4:46 AM
ftynse accepted this revision.Jun 11 2021, 10:09 AM
ftynse added a subscriber: ftynse.
ftynse added inline comments.
mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
298

No need for template here

This revision is now accepted and ready to land.Jun 11 2021, 10:09 AM
akuegel updated this revision to Diff 351774.Jun 13 2021, 10:53 PM

Address review comment.

akuegel added inline comments.Jun 13 2021, 10:54 PM
mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
298

Thanks :)
This was bad copy/paste from ComparisonOpConversion. I fixed it also in DivOpConversion.

This revision was landed with ongoing or failed builds.Jun 13 2021, 11:09 PM
This revision was automatically updated to reflect the committed changes.