Page MenuHomePhabricator

[mlir] Refactor ComplexOps.td [NFC]
ClosedPublic

Authored by akuegel on Jun 11 2021, 12:37 AM.

Details

Summary

Create a ComplexUnaryOp base class and use it for AbsOp, ReOp and ImOp.
Sort all ops in lexicographic order.

Diff Detail

Event Timeline

akuegel created this revision.Jun 11 2021, 12:37 AM
akuegel requested review of this revision.Jun 11 2021, 12:37 AM
pifon2a accepted this revision.Jun 11 2021, 12:42 AM

Nice! Thanks!

This revision is now accepted and ready to land.Jun 11 2021, 12:42 AM
akuegel updated this revision to Diff 351355.Jun 11 2021, 12:48 AM

Actually make it a NFC.

Nice! Thanks!

I actually made it a NFC, that is safer. If we want to add additional traits, I guess that should be a separate change.

akuegel retitled this revision from [mlir] Refactor ComplexOps.td to [mlir] Refactor ComplexOps.td [NFC].Jun 11 2021, 12:50 AM
akuegel edited the summary of this revision. (Show Details)
pifon2a accepted this revision.Jun 11 2021, 12:50 AM
This revision was landed with ongoing or failed builds.Jun 11 2021, 1:53 AM
This revision was automatically updated to reflect the committed changes.