This is an archive of the discontinued LLVM Phabricator instance.

Differential D104021

[clang-tidy] LIT test fix for Remark diagnostic
ClosedPublic

Authored by ivanmurashko on Jun 10 2021, 4:48 AM.

Details

Reviewers
aaron.ballman
alexfh
DmitryPolukhin
Commits
rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic
Summary

There is a followup fix for a unit test introduced at D102906. The test file was placed into a temp folder and test assumed that it would be visible without the full path specification.

This behaviour can be changed in future and it would be good to specify full path to the file at the test.

Test Plan:

ninja check-clang-tools

Diff Detail

Event Timeline

ivanmurashko created this revision.Jun 10 2021, 4:48 AM
Herald added a subscriber: xazax.hun. · View Herald TranscriptJun 10 2021, 4:48 AM
ivanmurashko requested review of this revision.Jun 10 2021, 4:48 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptJun 10 2021, 4:48 AM
ivanmurashko added a subscriber: 0x1eaf.Jun 10 2021, 4:49 AM
DmitryPolukhin accepted this revision.Jun 10 2021, 4:56 AM
LGTM
This revision is now accepted and ready to land.Jun 10 2021, 4:56 AM
Harbormaster completed remote builds in B108594: Diff 351133.Jun 10 2021, 5:26 AM
Closed by commit rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko, committed by DmitryPolukhin). · Explain WhyJun 11 2021, 2:03 AM
This revision was automatically updated to reflect the committed changes.
DmitryPolukhin added a commit: rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic.

Revision Contents

PathSize
clang-tools-extra/
test/
clang-tidy/
infrastructure/
5 lines

Diff 351368

clang-tools-extra/test/clang-tidy/infrastructure/remarks.cpp

// RUN: rm -rf %t // RUN: rm -rf %t
// RUN: cp -r %S/Inputs/remarks %t // RUN: cp -r %S/Inputs/remarks %t
// RUN: cp %s %t/t.cpp // RUN: cp %s %t/t.cpp
// RUN: clang-tidy -checks='-*,modernize-use-override,clang-diagnostic-module-import' t.cpp -- \ // RUN: clang-tidy -checks='-*,modernize-use-override,clang-diagnostic-module-import' %t/t.cpp -- \
// RUN: -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache \ // RUN: -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache \
// RUN: -fsyntax-only \ // RUN: -fsyntax-only \
// RUN: -I%S/Inputs/remarks \ // RUN: -I%S/Inputs/remarks \
// RUN: -working-directory=%t \ // RUN: -working-directory=%t \
// RUN: -Rmodule-build -Rmodule-import t.cpp 2>&1 |\ // RUN: -Rmodule-build -Rmodule-import 2>&1 |\
// RUN: FileCheck %s -implicit-check-not "remark:" // RUN: FileCheck %s -implicit-check-not "remark:"
#include "A.h" #include "A.h"
// CHECK: remark: importing module 'A' from {{.*}} [clang-diagnostic-module-import] // CHECK: remark: importing module 'A' from {{.*}} [clang-diagnostic-module-import]