In D159363#4636581, @kadircet wrote:

thanks, the fix LGTM as well.

but i wonder how this surfaces, to make sure we're taking necessary precautions in the future. we definitely have a dangling reference, which isn't great. but it's surprising that we access diags consumer during indexing.
I assume it's about the modules setup you're running clangd in. Do you have any stack traces that shows the execution path? my assumption is, this triggers when clangd ends up deserializing some symbols from a module. If these end up being important diagnostics, we might want to figure out how to emit diagnostics from these stages as well.

@sammccall's comment was addressed

The diff is not required after https://reviews.llvm.org/D145302 deployed

In D145302#4492595, @mstorsjo wrote:

In D145302#4491973, @glandium wrote:

This broke building with -DLLVM_LINK_LLVM_DYLIB=ON:

I also ran into this; I pushed a fix in a20d57e83441a69fa2bab86593b18cc0402095d2.

rebase before the final push

In D145302#4441334, @kadircet wrote:

thanks LG and seems to be working in a couple build configurations I tried. but there might still be breakages in different configs, so please be on the watchout after landing this for breakages in https://lab.llvm.org/.

Fixed clangd unit tests

small fixes

Rebase + apply suggestions from @kadircet

removed header install, only lib install has been left after the change

rebased to the latest LLVM main

rebase to latest LLVM main branch

Still looking at issues and not sure whether these are blockers or not.

typo fixed + rebase

windows marked as non supported

rebase

small fix at the lit-test

split-file was used for the lit-test simplification (see @ChuanqiXu comment)

Friendly ping

In D148088#4302269, @ilya-biryukov wrote:

Windows constrains added

Rebase

Commandeer the diff from @andrewjcg and made some changes at the code (get it compatible with latest clang source code) and at the tests (move modules artefacts to temp folder to make the test execution more stable).

@arphaman, @andrewjcg, what's the status of the diff?
The functionality is important for me and I want to get it landed.

Can this be solved at the build-system level, without changing the source code in ways that aren't otherwise useful?
For example, with a CLANG_TIDY_EXTRA_CHECKS cmake variable that adds more deps? This seems like it could also work for the clang-tidy binary.

If we consider the bare minimum with the only goal to build outside LLVM source tree then we don’t need to copy all internal headers. At the case the D145302 can be modified and we can end up with the only one header that is required to copy: clang-tools-extra/clangd/tool/ClangdMain.h.

The change addresses comments from D145228. The only one header is copied as a part of the installation. As result the diff contains the minimal changes required to integrated clangd into custom build systems (different from CMake).

In D145228#4174829, @sammccall wrote:

I think this is a bit abstract though. Concretely, what API do you need here? e.g. which headers do you want to include, to what end?

In D145228#4174543, @kadircet wrote:

Rebase

Use Invalid flag to detect invalid SLocEntry

In D130847#3693668, @aaron.ballman wrote:

These changes look reasonable, but I verified that the precommit CI failures are valid -- it looks like this change broke a test somehow; perhaps a caller was relying on the old behavior and needs to be reworked?

stop search if we could not load an entry

rebase

In D130847#3693668, @aaron.ballman wrote:

These changes look reasonable, but I verified that the precommit CI failures are valid -- it looks like this change broke a test somehow; perhaps a caller was relying on the old behavior and needs to be reworked?

In D130847#3690977, @aaron.ballman wrote:

Fix for wrong LastFileIDLookup assignment

rebase

LGTM, thank you a lot for the useful modification!

Some clarifications for the direct include example were added

Minor changes at the doc