Page MenuHomePhabricator

[LoopNest] Fix Wdeprecated-copy warnings
ClosedPublic

Authored by Whitney on Sat, Jun 5, 9:35 AM.

Details

Summary
error: definition of implicit copy constructor for 'LoopNest' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  LoopNest &operator=(const LoopNest &) = delete;

Diff Detail

Event Timeline

Whitney requested review of this revision.Sat, Jun 5, 9:35 AM
Whitney created this revision.
This revision is now accepted and ready to land.Tue, Jun 8, 7:08 AM
This revision was automatically updated to reflect the committed changes.
eugenis added a subscriber: eugenis.Tue, Jun 8, 1:08 PM

It appears that this change broke the sanitizer-windows bot:
https://lab.llvm.org/buildbot/#/builders/127/builds/12064

It appears that this change broke the sanitizer-windows bot:
https://lab.llvm.org/buildbot/#/builders/127/builds/12064

I am having problem reproducing it, and have emailed @rnk and @gkistanova to get help.

Try reverting it in the meantime?

Whitney reopened this revision.Tue, Jun 8, 1:47 PM
This revision is now accepted and ready to land.Tue, Jun 8, 1:47 PM

The buildbot went green before your revert has landed.
No idea what's going on, but this change does not seem to be the cause of it.

rnk added a comment.Wed, Jun 9, 2:54 PM

The buildbot went green before your revert has landed.
No idea what's going on, but this change does not seem to be the cause of it.

I saw the PDB related error and forced a clean build. That turned the bot green again.