Page MenuHomePhabricator

[mlir][NFC] Remove illegal TanhOp in LLVMConversionTarget
ClosedPublic

Authored by tpopp on May 30 2021, 11:42 PM.

Details

Summary

No tests fail and this seems to be technical debt from when the math
dialect was created. This should not be there as it prevents users from
configuring their converion target freely and results in unexpected
behavior on seemingly unrelated ops.

Diff Detail

Event Timeline

tpopp created this revision.May 30 2021, 11:42 PM
tpopp requested review of this revision.May 30 2021, 11:42 PM
ftynse accepted this revision.May 31 2021, 12:24 AM

Do this let us also remove the build/link dependency on the math dialect from this conversion?

This revision is now accepted and ready to land.May 31 2021, 12:24 AM
tpopp added a comment.May 31 2021, 1:40 AM

Do this let us also remove the build/link dependency on the math dialect from this conversion?

I just tried, but StandardToLLVM still has many Math lowerings in it