Page MenuHomePhabricator

WindowsSupport.h: do not depend on private config header
ClosedPublic

Authored by andrewrk on Sat, May 29, 1:44 PM.

Details

Summary

WindowsSupport.h is a public header, however if it gets included, will cause a compile error indicating that llvm/Config/config.h cannot be found, because config.h is a private header. However there is no actual dependency on the private things in this header, so it can be changed to the public config header.

Diff Detail

Event Timeline

andrewrk created this revision.Sat, May 29, 1:44 PM
andrewrk requested review of this revision.Sat, May 29, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, May 29, 1:44 PM
andrewrk edited the summary of this revision. (Show Details)Sat, May 29, 1:45 PM

I am still in the process of testing this change.

Confirmed, I have tested this change and it solves the problem.

amccarth accepted this revision.Tue, Jun 1, 11:40 AM
amccarth added a subscriber: amccarth.

LGTM.

This revision is now accepted and ready to land.Tue, Jun 1, 11:40 AM

Thank you for having a look, Adrian! I would appreciate if you or someone else could commit for me since I do not have write access.

Thank you for having a look, Adrian! I would appreciate if you or someone else could commit for me since I do not have write access.

Can you provide your preferred git author line in that case, i.e. Real Name <email@address>? (I'm sure I could dig up your signature somewhere too but asking in case you use multiple different ones) :-)

Andrew Kelley <andrew@ziglang.org>

Thanks Martin!

This revision was landed with ongoing or failed builds.Tue, Jun 1, 1:05 PM
This revision was automatically updated to reflect the committed changes.