This is an archive of the discontinued LLVM Phabricator instance.

Differential D103283

[mlir][capi] fix build issue with "all passes" registration
ClosedPublic

Authored by aartbik on May 27 2021, 1:34 PM.

Details

Reviewers
jpienaar
Commits
rGef1cc4e7aebe: [mlir][capi] fix build issue with "all passes" registration
Summary

Some builds exposed missing dependences on trafo/conv passes.

Diff Detail

Event Timeline

aartbik created this revision.May 27 2021, 1:34 PM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptMay 27 2021, 1:34 PM
aartbik requested review of this revision.May 27 2021, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 1:34 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik added a reviewer: jpienaar.May 27 2021, 1:35 PM
jpienaar accepted this revision.May 27 2021, 2:02 PM

This looks reasonable to me, thanks

This revision is now accepted and ready to land.May 27 2021, 2:02 PM
Harbormaster completed remote builds in B106593: Diff 348373.May 27 2021, 2:09 PM
Closed by commit rGef1cc4e7aebe: [mlir][capi] fix build issue with "all passes" registration (authored by aartbik). · Explain WhyMay 27 2021, 2:57 PM
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rGef1cc4e7aebe: [mlir][capi] fix build issue with "all passes" registration.

Revision Contents

PathSize
mlir/
lib/
CAPI/
Registration/
4 lines

Diff 348397

mlir/lib/CAPI/Registration/CMakeLists.txt

# Dialect registration. # Dialect registration.
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
get_property(translation_libs GLOBAL PROPERTY MLIR_TRANSLATION_LIBS)
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
add_mlir_public_c_api_library(MLIRCAPIRegistration add_mlir_public_c_api_library(MLIRCAPIRegistration
Registration.cpp Registration.cpp
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRCAPIIR MLIRCAPIIR
MLIRLLVMToLLVMIRTranslation MLIRLLVMToLLVMIRTranslation
${dialect_libs} ${dialect_libs}
${translation_libs}
${conversion_libs}
) )