[C++4OpenCL] Fix missing address space on implicit move assignment operator

[olestrohm]

Summary

This fixes the missing address space on this in the implicit move assignment operator.
The function called here is an abstraction around the lines that have been removed, and also sets the address space correctly.
This is copied from CopyConstructor, CopyAssignment and MoveConstructor, all of which use this new function, and now
MoveAssignment is has been aligned to use the same method.

I also added a new test file to check the output AST. If there's a better place for this test I will move it there.

Fixes: PR50259

[svenvh]

I also added a new test file to check the output AST. If there's a better place for this test I will move it there.

If you're primarily interested in the AST, then it doesn't have to be a Sema test I guess. In that case clang/test/AST seems to be a better place, and you could also remove the -verify parts of the test perhaps (unless you think it adds value that isn't tested elsewhere)?

clang/test/SemaOpenCLCXX/addrspace-assignment.clcpp

10

Maybe rename this struct to avoid any potential confusion with the implicit keyword in the dumps above? Even something as simple as S should do I think.

[olestrohm]

Cleaned up the test by renaming the struct and making the test compile.

The test has also been moved to clang/test/AST as suggested, since it really
just makes sure that the generated AST contains the correct implicit methods.

[svenvh]

LGTM!

[abhinavgaba]

clang/test/AST/ast-dump-implicit-members.clcpp

10 ↗

(On Diff #350200)

Could you please relax these checks? The test fails with -triple i386-pc-win32 with errors like this:

ast-dump-implicit-members.clcpp:10:11: error: CHECK: expected string not found in input
// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept'
          ^
<stdin>:1:1: note: scanning from here
Dumping __NSConstantString:
^
<stdin>:16:18: note: possible intended match here
|-CXXConstructorDecl 0x10b6c718 <col:8> col:8 implicit used constexpr S 'void () __attribute__((thiscall)) __generic noexcept' inline default trivial
                 ^

[olestrohm]

clang/test/AST/ast-dump-implicit-members.clcpp

10 ↗

(On Diff #350200)

Hi, sorry for this.
I have relaxed the tests in rGac677e69bdfc, so hopefully that should fix it.

[abhinavgaba]

clang/test/AST/ast-dump-implicit-members.clcpp

10 ↗

(On Diff #350200)

Thanks for the fix, @olestrohm.

clang/lib/Sema/SemaDeclCXX.cpp

CXXMethodDecl *Sema::DeclareImplicitMoveAssignment(CXXRecordDecl *ClassDecl) {
 
   if (getLangOpts().CUDA) {
     inferCUDATargetForImplicitSpecialMember(ClassDecl, CXXMoveAssignment,
                                             MoveAssignment,
                                             /* ConstRHS */ false,
                                             /* Diagnose */ false);
   }
 
-  // Build an exception specification pointing back at this member.
-  FunctionProtoType::ExtProtoInfo EPI =
-      getImplicitMethodEPI(*this, MoveAssignment);
-  MoveAssignment->setType(Context.getFunctionType(RetType, ArgType, EPI));
+  setupImplicitSpecialMemberType(MoveAssignment, RetType, ArgType);
 
   // Add the parameter to the operator.
   ParmVarDecl *FromParam = ParmVarDecl::Create(Context, MoveAssignment,
                                                ClassLoc, ClassLoc,
                                                /*Id=*/nullptr, ArgType,
                                                /*TInfo=*/nullptr, SC_None,
                                                nullptr);
   MoveAssignment->setParams(FromParam);

clang/test/SemaOpenCLCXX/addrspace-assignment.clcpp

+// RUN: %clang_cc1 %s -ast-dump -pedantic -verify | FileCheck %s
+
+
+// CHECK: CXXConstructorDecl {{.*}} implicit {{.*}} Implicit 'void (const __generic Implicit &) __generic'
+// CHECK: CXXConstructorDecl {{.*}} implicit {{.*}} Implicit 'void (__generic Implicit &&) __generic'
+// CHECK: CXXMethodDecl {{.*}} implicit {{.*}} operator= '__generic Implicit &(const __generic Implicit &) __generic'
+// CHECK: CXXMethodDecl {{.*}} implicit {{.*}} operator= '__generic Implicit &(__generic Implicit &&) __generic'
+// expected-note@+2{{candidate function (the implicit copy assignment operator) not viable: no known conversion from 'int' to 'const __generic Implicit' for 1st argument}}
+// expected-note@+1{{candidate function (the implicit move assignment operator) not viable: no known conversion from 'int' to '__generic Implicit' for 1st argument}}
+struct Implicit {};
+
+void f() {
+    Implicit i;
+    i = 10; // expected-error{{no viable overloaded '='}}
+}
+