Page MenuHomePhabricator

olestrohm (Ole Strohm)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2020, 8:43 AM (50 w, 5 d)

Recent Activity

Fri, Jun 11

olestrohm committed rGb102e6880ab0: [OpenCL] Fix overloading resolution of addrspace constructors (authored by olestrohm).
[OpenCL] Fix overloading resolution of addrspace constructors
Fri, Jun 11, 3:14 AM
olestrohm closed D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.
Fri, Jun 11, 3:14 AM · Restricted Project

Thu, Jun 10

olestrohm updated the diff for D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.

Added a comment explaining what the check is meant for.

Thu, Jun 10, 7:25 AM · Restricted Project
olestrohm added inline comments to D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator.
Thu, Jun 10, 2:45 AM · Restricted Project
olestrohm committed rGac677e69bdfc: [OpenCL] Relax test implicit members in C++ for OpenCL (authored by olestrohm).
[OpenCL] Relax test implicit members in C++ for OpenCL
Thu, Jun 10, 2:23 AM

Wed, Jun 9

olestrohm requested review of D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries.
Wed, Jun 9, 6:07 AM · Restricted Project
olestrohm added inline comments to D102689: [C++] Ignore top-level qualifiers in casts.
Wed, Jun 9, 4:38 AM · Restricted Project

Tue, Jun 8

olestrohm updated the diff for D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.

I've reverted to using Constructors and prioritizing based on which constructor is the most qualified.

Tue, Jun 8, 3:20 AM · Restricted Project
olestrohm updated the diff for D102689: [C++] Ignore top-level qualifiers in casts.

I've added a check in the constructor for CastOperator that removes qualifiers for non-class, non-array types.
I had to add a check for ObjectiveC, since they seem to use qualifiers for a lot of language features,
but maybe a better solution would be to remove specific qualifiers instead?

Tue, Jun 8, 3:07 AM · Restricted Project

Mon, Jun 7

olestrohm committed rG438cf5577e72: [OpenCL] Fix missing addrspace on implicit move assignment operator (authored by olestrohm).
[OpenCL] Fix missing addrspace on implicit move assignment operator
Mon, Jun 7, 2:04 AM
olestrohm closed D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator.
Mon, Jun 7, 2:04 AM · Restricted Project

Tue, Jun 1

olestrohm updated the diff for D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator.

Cleaned up the test by renaming the struct and making the test compile.

Tue, Jun 1, 7:21 AM · Restricted Project
olestrohm committed rG94b0aec0f5c6: [OpenCL] Fix ICE with invalid use of half (authored by olestrohm).
[OpenCL] Fix ICE with invalid use of half
Tue, Jun 1, 5:43 AM
olestrohm closed D103175: [C++4OpenCL] Fix ICE with invalid use of half.
Tue, Jun 1, 5:43 AM · Restricted Project
olestrohm added inline comments to D102689: [C++] Ignore top-level qualifiers in casts.
Tue, Jun 1, 2:43 AM · Restricted Project

Thu, May 27

olestrohm requested review of D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator.
Thu, May 27, 7:36 AM · Restricted Project

Wed, May 26

olestrohm requested review of D103175: [C++4OpenCL] Fix ICE with invalid use of half.
Wed, May 26, 8:48 AM · Restricted Project
olestrohm updated the diff for D102689: [C++] Ignore top-level qualifiers in casts.

I've cleaned up the check. The qualifiers of SrcType are removed prior to this function, so only DestType needs to have the address space removed.

Wed, May 26, 4:57 AM · Restricted Project
olestrohm added inline comments to D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.
Wed, May 26, 3:58 AM · Restricted Project
olestrohm updated the diff for D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.

Made the check more general, it's no longer OpenCL specific and no longer restricted to just constructors, since the check only requires them to be methods.

Wed, May 26, 3:00 AM · Restricted Project

Mon, May 24

olestrohm added inline comments to D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.
Mon, May 24, 5:35 AM · Restricted Project
olestrohm added inline comments to D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.
Mon, May 24, 3:36 AM · Restricted Project

May 21 2021

olestrohm retitled D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors from [C++4OpenCL] Allow address space conversion in reinterpret_cast to [C++4OpenCL] Fix overloading resolution of addrspace constructors.
May 21 2021, 1:22 AM · Restricted Project

May 20 2021

olestrohm requested review of D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors.
May 20 2021, 8:55 AM · Restricted Project

May 18 2021

olestrohm requested review of D102689: [C++] Ignore top-level qualifiers in casts.
May 18 2021, 7:00 AM · Restricted Project
olestrohm committed rG642d2f000b26: [OpenCL] Fix initialization of __constant constructors without arguments (authored by olestrohm).
[OpenCL] Fix initialization of __constant constructors without arguments
May 18 2021, 3:07 AM
olestrohm closed D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments.
May 18 2021, 3:07 AM · Restricted Project

May 17 2021

olestrohm updated the diff for D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments.

Relaxed the checks in the codegen test because of failures on platforms with slightly different IR being generated.

May 17 2021, 5:44 AM · Restricted Project
olestrohm committed rG66b112d624a5: [OpenCL] Fix reinterpret_cast of vectors (authored by olestrohm).
[OpenCL] Fix reinterpret_cast of vectors
May 17 2021, 4:44 AM
olestrohm closed D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.
May 17 2021, 4:44 AM · Restricted Project

May 14 2021

olestrohm updated the diff for D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.

Fixed the code style and added some comments to the tests.

May 14 2021, 7:52 AM · Restricted Project
olestrohm updated the diff for D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments.

Added a codegen test and clarified what some parts are testing.

May 14 2021, 7:42 AM · Restricted Project

May 12 2021

olestrohm added inline comments to D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments.
May 12 2021, 7:06 AM · Restricted Project

May 11 2021

olestrohm requested review of D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments.
May 11 2021, 9:00 AM · Restricted Project
olestrohm updated the diff for D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.

I tried to add a special case for 3 and 4 element vectors, but that caused issues in codgen, so I've left it as a FIXME for now.

May 11 2021, 8:38 AM · Restricted Project
olestrohm committed rG7d20f709ea6d: [OpenCL] [NFC] Fixed underline being too short in rst (authored by olestrohm).
[OpenCL] [NFC] Fixed underline being too short in rst
May 11 2021, 1:51 AM

May 7 2021

olestrohm updated the diff for D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.

Removed the address space related changes. This revision now only allows for reinterpret_cast between vectors of the same size.

May 7 2021, 4:59 AM · Restricted Project
olestrohm committed rGf372ff17f74f: [NFC] (test commit) Changed example invocation of C++ for OpenCL (authored by olestrohm).
[NFC] (test commit) Changed example invocation of C++ for OpenCL
May 7 2021, 4:32 AM

Apr 30 2021

olestrohm added inline comments to D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.
Apr 30 2021, 8:30 AM · Restricted Project
olestrohm updated the diff for D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.

Fixed formatting.

Apr 30 2021, 4:36 AM · Restricted Project
olestrohm updated the diff for D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters.

Fixed merge error

Apr 30 2021, 3:43 AM · Restricted Project

Apr 29 2021

olestrohm updated the diff for D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters.

Added a link to the C++ for OpenCL specification and cleaned up the text according to the requests.

Apr 29 2021, 8:28 AM · Restricted Project
olestrohm requested review of D101519: [C++4OpenCL] Fix reinterpret_cast of vectors.
Apr 29 2021, 4:14 AM · Restricted Project

Apr 27 2021

olestrohm retitled D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters from [C++4OpenCL] Add clang extension for unsafe kernel parameters to [C++4OpenCL] Add clang extension for non-portable kernel parameters.
Apr 27 2021, 4:40 AM · Restricted Project
olestrohm updated the diff for D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters.

Improved the description and example per the feedback.

Apr 27 2021, 4:39 AM · Restricted Project
olestrohm added inline comments to D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters.
Apr 27 2021, 3:27 AM · Restricted Project

Apr 23 2021

olestrohm requested review of D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters.
Apr 23 2021, 8:13 AM · Restricted Project
olestrohm updated the diff for D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.

I noticed that I could move the new check above the diagnostic for program scope variables, and the check during parsing can then be removed, while maintaining good diagnostics.

Apr 23 2021, 4:24 AM · Restricted Project

Apr 22 2021

olestrohm added a comment to D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.

The only ones that change (in the test cases at least) are as follows:
Here Old is with the current change, and New is with the call to diagnoseOpenCLTypes at parsing removed.

Apr 22 2021, 9:30 AM · Restricted Project

Apr 21 2021

olestrohm updated the diff for D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.

Renamed test as suggested.

Apr 21 2021, 8:38 AM · Restricted Project
olestrohm updated the diff for D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.

Ran git-clang-format.

Apr 21 2021, 5:31 AM · Restricted Project
olestrohm updated the diff for D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.

Inlined the thread_local check and moved static clk_event_t into the appropriate test.
I did not move the thread_local check since NewVD had the wrong value for TSCS, so D was required.

Apr 21 2021, 4:09 AM · Restricted Project

Apr 20 2021

olestrohm requested review of D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates.
Apr 20 2021, 8:28 AM · Restricted Project

Apr 16 2021

olestrohm updated the diff for D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.

Restricted the checks to C++ for OpenCL and added another test for OpenCL vector types.

Apr 16 2021, 2:26 AM · Restricted Project

Apr 15 2021

olestrohm added inline comments to D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.
Apr 15 2021, 9:14 AM · Restricted Project

Apr 14 2021

olestrohm updated the diff for D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.

Added more exhaustive tests, as well as fixed the diagnostic to allow reference types.

Apr 14 2021, 7:55 AM · Restricted Project
olestrohm requested review of D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.
Apr 14 2021, 5:13 AM · Restricted Project

Aug 7 2020

olestrohm updated the diff for D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL.

I have amended the relevant test to validate this behaviour in C++ for OpenCL.

Aug 7 2020, 8:21 AM · Restricted Project

Aug 6 2020

olestrohm requested review of D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL.
Aug 6 2020, 6:02 AM · Restricted Project

Jul 21 2020

olestrohm updated the diff for D83665: [OpenCL] Fixed missing address space for templated copy constructor.

The code now directly adds the __generic address space to the pointee type.

Jul 21 2020, 4:48 AM · Restricted Project

Jul 20 2020

olestrohm added inline comments to D83665: [OpenCL] Fixed missing address space for templated copy constructor.
Jul 20 2020, 4:08 AM · Restricted Project

Jul 13 2020

olestrohm created D83665: [OpenCL] Fixed missing address space for templated copy constructor.
Jul 13 2020, 3:25 AM · Restricted Project

Jul 8 2020

olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

I've removed the comments calling for a fix because I no longer feel that this approach needs that. Given the code that already exists, and without changing too much of it, adding address space deduction in both cases seems like the right choice.

Jul 8 2020, 4:27 AM · Restricted Project

Jul 3 2020

olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

I have added a check in deduceOpenCLAddressSpace() to check if the type is dependent, and not deduce the address space if it is. This is a big change in the behaviour of address space deduction, meaning that template variables only receive address spaces when they are being specialized. This is good, but caused a lot of changes in the current test file, which has been included in this patch.

Jul 3 2020, 6:58 AM · Restricted Project
olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

Disregard the last comment, rolling back that diff for now.

Jul 3 2020, 4:16 AM · Restricted Project
olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

Added a guard in deduceOpenCLAddressSpace to stop it from deducing address space for dependent types, as requested.

Jul 3 2020, 3:44 AM · Restricted Project

Jun 30 2020

olestrohm added a comment to D82781: [OpenCL] Fix missing address space deduction in template variables.

Essentially, in each pass the type for the variable starts off being extract from the SourceTypeInfo, but since the address space isn't specified, this type is then missing an address space.
Adding the address space deduction then reintroduces the address space to the type.

Jun 30 2020, 2:08 AM · Restricted Project

Jun 29 2020

olestrohm created D82781: [OpenCL] Fix missing address space deduction in template variables.
Jun 29 2020, 9:10 AM · Restricted Project