Page MenuHomePhabricator

olestrohm (Ole Strohm)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2020, 8:43 AM (6 w, 2 d)

Recent Activity

Fri, Aug 7

olestrohm updated the diff for D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL.

I have amended the relevant test to validate this behaviour in C++ for OpenCL.

Fri, Aug 7, 8:21 AM · Restricted Project

Thu, Aug 6

olestrohm requested review of D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL.
Thu, Aug 6, 6:02 AM · Restricted Project

Tue, Jul 21

olestrohm updated the diff for D83665: [OpenCL] Fixed missing address space for templated copy constructor.

The code now directly adds the __generic address space to the pointee type.

Tue, Jul 21, 4:48 AM · Restricted Project

Mon, Jul 20

olestrohm added inline comments to D83665: [OpenCL] Fixed missing address space for templated copy constructor.
Mon, Jul 20, 4:08 AM · Restricted Project

Jul 13 2020

olestrohm created D83665: [OpenCL] Fixed missing address space for templated copy constructor.
Jul 13 2020, 3:25 AM · Restricted Project

Jul 8 2020

olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

I've removed the comments calling for a fix because I no longer feel that this approach needs that. Given the code that already exists, and without changing too much of it, adding address space deduction in both cases seems like the right choice.

Jul 8 2020, 4:27 AM · Restricted Project

Jul 3 2020

olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

I have added a check in deduceOpenCLAddressSpace() to check if the type is dependent, and not deduce the address space if it is. This is a big change in the behaviour of address space deduction, meaning that template variables only receive address spaces when they are being specialized. This is good, but caused a lot of changes in the current test file, which has been included in this patch.

Jul 3 2020, 6:58 AM · Restricted Project
olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

Disregard the last comment, rolling back that diff for now.

Jul 3 2020, 4:16 AM · Restricted Project
olestrohm updated the diff for D82781: [OpenCL] Fix missing address space deduction in template variables.

Added a guard in deduceOpenCLAddressSpace to stop it from deducing address space for dependent types, as requested.

Jul 3 2020, 3:44 AM · Restricted Project

Jun 30 2020

olestrohm added a comment to D82781: [OpenCL] Fix missing address space deduction in template variables.

Essentially, in each pass the type for the variable starts off being extract from the SourceTypeInfo, but since the address space isn't specified, this type is then missing an address space.
Adding the address space deduction then reintroduces the address space to the type.

Jun 30 2020, 2:08 AM · Restricted Project

Jun 29 2020

olestrohm created D82781: [OpenCL] Fix missing address space deduction in template variables.
Jun 29 2020, 9:10 AM · Restricted Project