Page MenuHomePhabricator

[mlir] StandardToLLVM: option to disable AllocOp lowering
ClosedPublic

Authored by Hardcode84 on May 27 2021, 3:52 AM.

Diff Detail

Event Timeline

Hardcode84 created this revision.May 27 2021, 3:52 AM
Hardcode84 requested review of this revision.May 27 2021, 3:52 AM
ftynse accepted this revision.May 27 2021, 3:59 AM
This revision is now accepted and ready to land.May 27 2021, 3:59 AM
bondhugula added inline comments.
mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVMPass.h
47

User must provide his -> Users must provide their

bondhugula requested changes to this revision.May 27 2021, 7:30 AM
bondhugula added inline comments.
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
4147

Can you please add an assertion message?

This revision now requires changes to proceed.May 27 2021, 7:30 AM

review comments

bondhugula accepted this revision.May 30 2021, 2:28 AM
This revision is now accepted and ready to land.May 30 2021, 2:28 AM

rebase, rerun tests