[lldb] add LLDB_SKIP_DSYM option

[rmaz]

Summary

Add an option to skip generating a dSYM when installing the LLDB framework on Darwin.

[smeenai]

Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO.

LGTM. Do you need this to be committed for you?

[rmaz]

In D103124#2780955, @smeenai wrote:

Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO.

LGTM. Do you need this to be committed for you?

If you could, thanks

lldb/cmake/modules/AddLLDB.cmake

else()
     else()
       # Only ever install shared libraries.
       set(output_name "lib${output_name}.dylib")
       set(buildtree_dir ${LLVM_LIBRARY_OUTPUT_INTDIR})
     endif()
   endif()
 
   # Generate dSYM
+  if(NOT LLDB_SKIP_DSYM)
     set(dsym_name ${output_name}.dSYM)
     if(is_framework)
       set(dsym_name ${output_name}.framework.dSYM)
     endif()
     if(LLDB_DEBUGINFO_INSTALL_PREFIX)
       # This makes the path absolute, so we must respect DESTDIR.
       set(dsym_name "\$ENV\{DESTDIR\}${LLDB_DEBUGINFO_INSTALL_PREFIX}/${dsym_name}")
     endif()
 
     set(buildtree_name ${buildtree_dir}/${bundle_subdir}${output_name})
     install(CODE "message(STATUS \"Externalize debuginfo: ${dsym_name}\")" COMPONENT ${name})
     install(CODE "execute_process(COMMAND xcrun dsymutil -o=${dsym_name} ${buildtree_name})"
             COMPONENT ${name})
+  endif()
 
   if(NOT LLDB_SKIP_STRIP)
     # Strip distribution binary with -ST (removing debug symbol table entries and
     # Swift symbols). Avoid CMAKE_INSTALL_DO_STRIP and llvm_externalize_debuginfo()
     # as they can't be configured sufficiently.
     set(installtree_name "\$ENV\{DESTDIR\}${install_prefix}/${bundle_subdir}${output_name}")
     install(CODE "message(STATUS \"Stripping: ${installtree_name}\")" COMPONENT ${name})
     install(CODE "execute_process(COMMAND xcrun strip -ST ${installtree_name})"

lldb/cmake/modules/LLDBConfig.cmake

 add_optional_dependency(LLDB_ENABLE_LIBXML2 "Enable Libxml 2 support in LLDB" LibXml2 LIBXML2_FOUND VERSION 2.8)
 
 option(LLDB_USE_SYSTEM_SIX "Use six.py shipped with system and do not install a copy of it" OFF)
 option(LLDB_USE_ENTITLEMENTS "When codesigning, use entitlements if available" ON)
 option(LLDB_BUILD_FRAMEWORK "Build LLDB.framework (Darwin only)" OFF)
 option(LLDB_NO_INSTALL_DEFAULT_RPATH "Disable default RPATH settings in binaries" OFF)
 option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver for testing (Darwin only)." OFF)
 option(LLDB_SKIP_STRIP "Whether to skip stripping of binaries when installing lldb." OFF)
+option(LLDB_SKIP_DSYM "Whether to skip generating a dSYM when installing lldb." OFF)
 
 if (LLDB_USE_SYSTEM_DEBUGSERVER)
   # The custom target for the system debugserver has no install target, so we
   # need to remove it from the LLVM_DISTRIBUTION_COMPONENTS list.
   if (LLVM_DISTRIBUTION_COMPONENTS)
     list(REMOVE_ITEM LLVM_DISTRIBUTION_COMPONENTS debugserver)
     set(LLVM_DISTRIBUTION_COMPONENTS ${LLVM_DISTRIBUTION_COMPONENTS} CACHE STRING "" FORCE)
   endif()