For the ocean and srad benchmarks, RAND_MAX is used and is expected to be 2147483647.
However, RAND_MAX on AIX is actually 32767. Thus, we use INT_MAX instead as INT_MAX is 2147483647.
Details
Details
- Reviewers
stevewan daltenty hubert.reinterpretcast - Group Reviewers
Restricted Project - Commits
- rT66ac0dcd149a: [AIX][test-suite] Utilize `INT_MAX` instead of `RAND_MAX` on AIX (ocean and…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Gentle ping.
@hubert.reinterpretcast @ZarkoCA @stevewan @daltenty Did any of you have any comments regarding this change?
Comment Actions
Perhaps consider using 2147483647.0 directly as the divisor so that no extra header is needed?
Comment Actions
Address @stevewan's review comment to use 2147483647 instead of including a new header.
I have tried to define a macro to represent 2147483647 on AIX.
Comment Actions
LGTM with minor nit. Thanks.
MultiSource/Benchmarks/Rodinia/srad/main.c | ||
---|---|---|
86 | nit: The indentation is slightly different from the change in the other file. Possibly run through clang-format to make sure. |
nit: The indentation is slightly different from the change in the other file. Possibly run through clang-format to make sure.