[AIX][test-suite] Utilize `INT_MAX` instead of `RAND_MAX` on AIX (ocean and srad benchmarks)

[amyk]

Summary

For the ocean and srad benchmarks, RAND_MAX is used and is expected to be 2147483647.
However, RAND_MAX on AIX is actually 32767. Thus, we use INT_MAX instead as INT_MAX is 2147483647.

[amyk]

Ping.

[amyk]

Ping.

[amyk]

Gentle ping.
@hubert.reinterpretcast @ZarkoCA @stevewan @daltenty Did any of you have any comments regarding this change?

[amyk]

Gentle ping.

[stevewan]

Perhaps consider using 2147483647.0 directly as the divisor so that no extra header is needed?

[amyk]

Address @stevewan's review comment to use 2147483647 instead of including a new header.
I have tried to define a macro to represent 2147483647 on AIX.

[stevewan]

LGTM with minor nit. Thanks.

MultiSource/Benchmarks/Rodinia/srad/main.c

86

nit: The indentation is slightly different from the change in the other file. Possibly run through clang-format to make sure.

MultiSource/Benchmarks/Prolangs-C++/ocean/ocean.cpp

 #include "constants.hh"
 #include "random.hh"
 #include "coordinate.hh"
 #include "ocean.hh"
 #include "cell.hh"
 #include "prey.hh"
 #include "predator.hh"
 #include "obstacle.hh"
 
 #include <cstdlib>
 
 #if defined(__XS1B__)
 #include "xcoretestsuite.h"
 #endif
+#ifdef _AIX
+#define AIX_RAND_MAX 2147483647
+#endif
 
 //cell.cc
 Cell *Cell::getCellAt(Coordinate aCoord) {
   return cells[aCoord.getY()][aCoord.getX()];
 }
 
 void Cell::assignCellAt(Coordinate aCoord, Cell *aCell) {
   cells[aCoord.getY()][aCoord.getX()] = aCell;
Cell *Predator::reproduce(Coordinate anOffset) {
   Ocean1->setNumPredators(Ocean1->getNumPredators()+1);
   return (Cell *) temp;
 }
 
 //random.cc
 #define MAX 32767
 
 float Random::randReal(void) {
+#ifdef _AIX
+  return random()/(float)AIX_RAND_MAX;
+#else
   return random()/(float)RAND_MAX;
+#endif
 }
 
 unsigned Random::nextIntBetween(int low, int high) {
+#ifdef _AIX
+  return (long long)(random())* high / AIX_RAND_MAX;
+#else
   return (long long)(random())* high / RAND_MAX;
+#endif
 }
 
 //ocean.cc
 void Ocean::initialize(void) {
   random = new Random();
   random->initialize();
   numRows = MaxRows;
   numCols = MaxCols;

MultiSource/Benchmarks/Rodinia/srad/main.c

 #include "glibc_compat_rand.h"
 #include "srad.h"
 #include <math.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#ifdef _AIX
+#define AIX_RAND_MAX 2147483647
+#endif
 void random_matrix(float I[ROWS][COLS]);
 void srad_kernel(float dN[ROWS][COLS], float dS[ROWS][COLS],
                  float dW[ROWS][COLS], float dE[ROWS][COLS],
                  float I[ROWS][COLS], float J[ROWS][COLS], float c[ROWS][COLS]);
 
 int main(int argc, char *argv[]) {
   int size_I;
 
int main(int argc, char *argv[]) {
   return 0;
 }
 
 void random_matrix(float I[ROWS][COLS]) {
 
   glibc_compat_srand(SEED);
   for (int i = 0; i < ROWS; i++) {
     for (int j = 0; j < COLS; j++) {
+      #ifdef _AIX
+      I[i][j] = glibc_compat_rand() / (float)AIX_RAND_MAX;
+      #else
       I[i][j] = glibc_compat_rand() / (float)RAND_MAX;
+      #endif
     }
   }
 }