Page MenuHomePhabricator

[mlir] Add convenience builders for EqualOp and NotEqualOp.
ClosedPublic

Authored by akuegel on May 21 2021, 1:39 AM.

Details

Summary

The result type is always I1. This additional builder allows to omit the result type.

Diff Detail

Event Timeline

akuegel created this revision.May 21 2021, 1:39 AM
akuegel requested review of this revision.May 21 2021, 1:39 AM
pifon2a accepted this revision.May 21 2021, 2:31 AM

Thank you, Adrian!

This revision is now accepted and ready to land.May 21 2021, 2:31 AM

Thanks!

mlir/include/mlir/Dialect/Complex/IR/ComplexOps.td
171

Would $_builder.getI1Type() work?

215

nit: see above

akuegel added inline comments.May 21 2021, 2:43 AM
mlir/include/mlir/Dialect/Complex/IR/ComplexOps.td
171

Yes, that works and is better. Thanks :)
Will land this in a followup commit.