This is an archive of the discontinued LLVM Phabricator instance.

Differential D102881

[mlir] Rename MlirLspServerLib -> MLIRLspServerLib
ClosedPublic

Authored by kwk on May 20 2021, 3:30 PM.

Details

Reviewers
serge-sans-paille
rriddle
Commits
rG0297506d20df: [mlir] Rename MlirLspServerLib -> MLIRLspServerLib
Summary

I noticed while packaging mlir that most mlir library names start
with libMLIR. The only different libary was libMlirLspServerLib.a.

That's why I changed the library to be similarly named to the others.

Diff Detail

Event Timeline

kwk created this revision.May 20 2021, 3:30 PM
Herald added subscribers: dcaballe, cota, teijeong and 17 others. · View Herald TranscriptMay 20 2021, 3:30 PM
kwk requested review of this revision.May 20 2021, 3:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2021, 3:30 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
kwk added a reviewer: serge-sans-paille.May 20 2021, 3:30 PM
rriddle accepted this revision.May 20 2021, 3:34 PM
This revision is now accepted and ready to land.May 20 2021, 3:34 PM
Harbormaster completed remote builds in B105523: Diff 346872.May 20 2021, 4:03 PM
Closed by commit rG0297506d20df: [mlir] Rename MlirLspServerLib -> MLIRLspServerLib (authored by kwk). · Explain WhyMay 21 2021, 1:26 AM
This revision was automatically updated to reflect the committed changes.
kwk added a commit: rG0297506d20df: [mlir] Rename MlirLspServerLib -> MLIRLspServerLib.

Revision Contents

PathSize
mlir/
lib/
Tools/
mlir-lsp-server/
2 lines
tools/
mlir-lsp-server/
2 lines

Diff 346950

mlir/lib/Tools/mlir-lsp-server/CMakeLists.txt

add_mlir_library(MlirLspServerLib add_mlir_library(MLIRLspServerLib
lsp/Logging.cpp lsp/Logging.cpp
lsp/Protocol.cpp lsp/Protocol.cpp
lsp/Transport.cpp lsp/Transport.cpp
LSPServer.cpp LSPServer.cpp
MLIRServer.cpp MLIRServer.cpp
MlirLspServerMain.cpp MlirLspServerMain.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Tools/mlir-lsp-server ${MLIR_MAIN_INCLUDE_DIR}/mlir/Tools/mlir-lsp-server
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRParser MLIRParser
) )

mlir/tools/mlir-lsp-server/CMakeLists.txt

Show All 27 Lines
set(LIBS set(LIBS
${dialect_libs} ${dialect_libs}
${conversion_libs} ${conversion_libs}
${test_libs} ${test_libs}
MLIRLoopAnalysis MLIRLoopAnalysis
MLIRAnalysis MLIRAnalysis
MLIRDialect MLIRDialect
MLIREDSC MLIREDSC
MlirLspServerLib MLIRLspServerLib
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRTransforms MLIRTransforms
MLIRTransformUtils MLIRTransformUtils
MLIRSupport MLIRSupport
MLIRIR MLIRIR
) )
Show All 10 Lines