This is an archive of the discontinued LLVM Phabricator instance.

[Driver][test] Don't assume integrated-as
ClosedPublic

Authored by jsji on May 17 2021, 12:35 PM.

Download Raw Diff

Details

Reviewers

thakis
MaskRay
phosek
hubert.reinterpretcast

Group Reviewers

Restricted Project

Commits

rG82b52812471c: [Driver][test] Don't assume integrated-as

Summary

The tests of fdebug-compilation-dir and -ffile-compilation-dir for `-x
assembler` are assuming integrated-as.
If the platform set the no-itegrated-as by default (eg: AIX for now), then this test will
fail.

Add the -integrated-as to aviod relying on the platform defaults.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jsji requested review of this revision.May 17 2021, 12:35 PM

jsji created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2021, 12:35 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Are there any platforms left that don't default to integrated as? Which ones? Is there a tracking bug for switching them?

This revision is now accepted and ready to land.May 17 2021, 12:49 PM

In D102647#2764376, @thakis wrote:

Are there any platforms left that don't default to integrated as? Which ones? Is there a tracking bug for switching them?

Thanks! Oh, I should have mentioned that in description, this is exposed on AIX testing.
AIX doesn't default to integrated as for now. There is no tracking bug externally yet, but we have internal tracking for switching.

jsji edited the summary of this revision. (Show Details)May 17 2021, 12:56 PM

Harbormaster completed remote builds in B104888: Diff 345969.May 17 2021, 1:17 PM

Closed by commit rG82b52812471c: [Driver][test] Don't assume integrated-as (authored by jsji). · Explain WhyMay 17 2021, 1:24 PM

This revision was automatically updated to reflect the committed changes.

jsji added a commit: rG82b52812471c: [Driver][test] Don't assume integrated-as.

Revision Contents

Path

Size

clang/

test/

Driver/

clang_f_opts.c

6 lines

Diff 345986

clang/test/Driver/clang_f_opts.c

	Show First 20 Lines • Show All 510 Lines • ▼ Show 20 Lines
	// CHECK-NO-CF-PROTECTION-RETURN-NOT: -fcf-protection=return			// CHECK-NO-CF-PROTECTION-RETURN-NOT: -fcf-protection=return
	// RUN: %clang -### -S -fcf-protection=branch %s 2>&1 \| FileCheck -check-prefix=CHECK-CF-PROTECTION-BRANCH %s			// RUN: %clang -### -S -fcf-protection=branch %s 2>&1 \| FileCheck -check-prefix=CHECK-CF-PROTECTION-BRANCH %s
	// RUN: %clang -### -S %s 2>&1 \| FileCheck -check-prefix=CHECK-NO-CF-PROTECTION-BRANCH %s			// RUN: %clang -### -S %s 2>&1 \| FileCheck -check-prefix=CHECK-NO-CF-PROTECTION-BRANCH %s
	// CHECK-CF-PROTECTION-BRANCH: -fcf-protection=branch			// CHECK-CF-PROTECTION-BRANCH: -fcf-protection=branch
	// CHECK-NO-CF-PROTECTION-BRANCH-NOT: -fcf-protection=branch			// CHECK-NO-CF-PROTECTION-BRANCH-NOT: -fcf-protection=branch

	// RUN: %clang -### -S -fdebug-compilation-dir . %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -S -fdebug-compilation-dir . %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s
	// RUN: %clang -### -S -fdebug-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -S -fdebug-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s
	// RUN: %clang -### -fdebug-compilation-dir . -x assembler %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -integrated-as -fdebug-compilation-dir . -x assembler %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s
	// RUN: %clang -### -fdebug-compilation-dir=. -x assembler %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -integrated-as -fdebug-compilation-dir=. -x assembler %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s
	// RUN: %clang -### -S -ffile-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -S -ffile-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-DEBUG-COMPILATION-DIR %s
	// RUN: %clang -### -ffile-compilation-dir=. -x assembler %s 2>&1 \| FileCheck -check-prefixes=CHECK-DEBUG-COMPILATION-DIR %s			// RUN: %clang -### -integrated-as -ffile-compilation-dir=. -x assembler %s 2>&1 \| FileCheck -check-prefixes=CHECK-DEBUG-COMPILATION-DIR %s
	// CHECK-DEBUG-COMPILATION-DIR: "-fdebug-compilation-dir=."			// CHECK-DEBUG-COMPILATION-DIR: "-fdebug-compilation-dir=."
	// CHECK-DEBUG-COMPILATION-DIR-NOT: "-ffile-compilation-dir=."			// CHECK-DEBUG-COMPILATION-DIR-NOT: "-ffile-compilation-dir=."

	// RUN: %clang -### -S -fprofile-instr-generate -fcoverage-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-COVERAGE-COMPILATION-DIR %s			// RUN: %clang -### -S -fprofile-instr-generate -fcoverage-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-COVERAGE-COMPILATION-DIR %s
	// RUN: %clang -### -S -fprofile-instr-generate -ffile-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-COVERAGE-COMPILATION-DIR %s			// RUN: %clang -### -S -fprofile-instr-generate -ffile-compilation-dir=. %s 2>&1 \| FileCheck -check-prefix=CHECK-COVERAGE-COMPILATION-DIR %s
	// CHECK-COVERAGE-COMPILATION-DIR: "-fcoverage-compilation-dir=."			// CHECK-COVERAGE-COMPILATION-DIR: "-fcoverage-compilation-dir=."
	// CHECK-COVERAGE-COMPILATION-DIR-NOT: "-ffile-compilation-dir=."			// CHECK-COVERAGE-COMPILATION-DIR-NOT: "-ffile-compilation-dir=."

	▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines