This is an archive of the discontinued LLVM Phabricator instance.

Differential D102560

[AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as
ClosedPublic

Authored by hubert.reinterpretcast on May 15 2021, 1:34 PM.

Details

Reviewers
v.g.vassilev
lhames
daltenty
jasonliu
jsji
Commits
rG9ae529d0db2d: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as
Summary

This patch replaces the powerpc64 token with the system-aix one in the UNSUPPORTED line of a test. The powerpc64 token was originally added temporarily in 71a0609a2b53.

If AIX uses integrated-as by default and it works both for 32-bit and 64-bit objects, then the issues encountered so far (see comments in D96033) would be mostly solved.

As it is, marking the test as expected-to-fail (as opposed to unsupported) on AIX might cause more trouble in the form of 32-bit versus 64-bit differences. I am not aware of other situations where LIT tests are dependent on whether the LLVM build is 64-bit or 32-bit.

Diff Detail

Revision Contents

PathSize
clang/
test/
Interpreter/
2 lines

Diff 345661

clang/test/Interpreter/execute.cpp

// RUN: cat %s | clang-repl | FileCheck %s // RUN: cat %s | clang-repl | FileCheck %s
// REQUIRES: host-supports-jit // REQUIRES: host-supports-jit
// UNSUPPORTED: powerpc64 // UNSUPPORTED: system-aix
extern "C" int printf(const char *, ...); extern "C" int printf(const char *, ...);
int i = 42; int i = 42;
auto r1 = printf("i = %d\n", i); auto r1 = printf("i = %d\n", i);
// CHECK: i = 42 // CHECK: i = 42
struct S { float f = 1.0; S *m = nullptr;} s; struct S { float f = 1.0; S *m = nullptr;} s;
auto r2 = printf("S[f=%f, m=0x%llx]\n", s.f, reinterpret_cast<unsigned long long>(s.m)); auto r2 = printf("S[f=%f, m=0x%llx]\n", s.f, reinterpret_cast<unsigned long long>(s.m));
// CHECK-NEXT: S[f=1.000000, m=0x0] // CHECK-NEXT: S[f=1.000000, m=0x0]
quit quit