This is an archive of the discontinued LLVM Phabricator instance.

[AIX][AsmPrinter] Print Global Variable in comments
ClosedPublic

Authored by jsji on May 14 2021, 2:28 PM.

Details

Summary

The default AsmPrinter print GV in comments,
AIX should do so too.

This also fix LLVM :: CodeGen/Generic/inline-asm-mem-clobber.ll.

Diff Detail

Event Timeline

jsji created this revision.May 14 2021, 2:28 PM
jsji requested review of this revision.May 14 2021, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2021, 2:28 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2186

I looks to me that the corresponding code in AsmPrinter::emitGlobalVariable is guarded by GV->hasInitializer().

jsji marked an inline comment as done.May 15 2021, 7:21 PM
jsji added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2186

Good point, we should align.

jsji updated this revision to Diff 345660.May 15 2021, 7:21 PM
jsji marked an inline comment as done.

Address comments.

This revision is now accepted and ready to land.May 15 2021, 7:35 PM
This revision was automatically updated to reflect the committed changes.