This is an archive of the discontinued LLVM Phabricator instance.

Differential D102525

[MLIR] Document that Dialect Conversion traverses in preorder
ClosedPublic

Authored by GMNGeoffrey on May 14 2021, 12:45 PM.

Details

Reviewers
rriddle
Commits
rG4f6ec382c8b7: [MLIR] Document that Dialect Conversion traverses in preorder

Diff Detail

Event Timeline

GMNGeoffrey created this revision.May 14 2021, 12:45 PM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptMay 14 2021, 12:45 PM
GMNGeoffrey requested review of this revision.May 14 2021, 12:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2021, 12:45 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
GMNGeoffrey updated this revision to Diff 345533.May 14 2021, 12:46 PM
  • Fix spacing
GMNGeoffrey added a reviewer: rriddle.May 14 2021, 12:46 PM
Harbormaster completed remote builds in B104572: Diff 345533.May 14 2021, 1:13 PM
rriddle accepted this revision.Jun 10 2021, 10:24 AM

Thanks. (Sorry, missed this somehow)

This revision is now accepted and ready to land.Jun 10 2021, 10:24 AM
Closed by commit rG4f6ec382c8b7: [MLIR] Document that Dialect Conversion traverses in preorder (authored by GMNGeoffrey). · Explain WhyJun 10 2021, 3:09 PM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG4f6ec382c8b7: [MLIR] Document that Dialect Conversion traverses in preorder.

Revision Contents

PathSize
mlir/
docs/
3 lines

Diff 345533

mlir/docs/DialectConversion.md

Show All 39 Lines* Analysis Conversion
- An analysis conversion will analyze which operations are legalizable to - An analysis conversion will analyze which operations are legalizable to
the given conversion target if a conversion were to be applied. This is the given conversion target if a conversion were to be applied. This is
done by performing a 'partial' conversion and recording which operations done by performing a 'partial' conversion and recording which operations
would have been successfully converted if successful. Note that no would have been successfully converted if successful. Note that no
rewrites, or transformations, are actually applied to the input rewrites, or transformations, are actually applied to the input
operations. operations.
- An analysis conversion can be applied via `applyAnalysisConversion`. - An analysis conversion can be applied via `applyAnalysisConversion`.
In all cases, the framework walks the operations in preorder, examining an op
before the ops in any regions it has.
## Conversion Target ## Conversion Target
The conversion target is a formal definition of what is considered to be legal The conversion target is a formal definition of what is considered to be legal
during the conversion process. The final operations generated by the conversion during the conversion process. The final operations generated by the conversion
framework must be marked as legal on the `ConversionTarget` for the rewrite to framework must be marked as legal on the `ConversionTarget` for the rewrite to
be a success. Depending on the conversion mode, existing operations need not be a success. Depending on the conversion mode, existing operations need not
always be legal. Operations and dialects may be marked with any of the provided always be legal. Operations and dialects may be marked with any of the provided
legality actions below: legality actions below:
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines