This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Set FileSystem for tweaks in Check tool.
ClosedPublic

Authored by usaxena95 on May 14 2021, 11:26 AM.

Details

Summary

Tweaks like DefineOutline depend on FS to be set at apply() time.
After https://reviews.llvm.org/D93978, tweaks run from Check tool lost
access to FS. This makes the available to apply() once again.

Diff Detail

Event Timeline

usaxena95 created this revision.May 14 2021, 11:26 AM
usaxena95 requested review of this revision.May 14 2021, 11:26 AM

thanks, lgtm!

clang-tools-extra/clangd/tool/Check.cpp
215

IIUC, the ordering here is to ensure FS is not available during prepare but exists in apply. That sounds sane, as we would like prepare to be fast, and IO is likely slow.
But this is very subtle, so deserves a comment.

usaxena95 updated this revision to Diff 345793.May 17 2021, 2:09 AM
usaxena95 marked an inline comment as done.

added comment.

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2021, 2:10 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
usaxena95 added a comment.EditedMay 17 2021, 2:13 AM

Did you need any other change ? Didn't realise the revision was not "accepted".

oops, sorry. i thought i've accepted the revision already :D