This is an archive of the discontinued LLVM Phabricator instance.

[clangd][QueryDriver] Dont check for existence of driver
ClosedPublic

Authored by kadircet on May 13 2021, 11:58 AM.

Details

Summary

Execute implementations already checks for permissions and existence
and returns relevant errors as necessary, so instead of printing our own errors,
we just print theirs.

This also fixes a case in windows where the driver might be missing the .exe
suffix. Previously, clangd would reject such a driver because sys::fs::exists is
strict, whereas the underlying Execute implementation would check with .exe
suffix too.

Fixes https://github.com/clangd/clangd/issues/93

Diff Detail

Event Timeline

kadircet created this revision.May 13 2021, 11:58 AM
kadircet requested review of this revision.May 13 2021, 11:58 AM
hokein accepted this revision.May 16 2021, 11:26 PM
This revision is now accepted and ready to land.May 16 2021, 11:26 PM
This revision was automatically updated to reflect the committed changes.