This is an archive of the discontinued LLVM Phabricator instance.

Differential D102250

[TextAPI] Reformat llvm_unreachable message
ClosedPublic

Authored by spowell on May 11 2021, 9:19 AM.

Details

Reviewers
cishida
ributzka
steven_wu
zixuw
JDevlieghere
Commits
rGcba508fb6787: [TextAPI] Reformat llvm_unreachable message
Summary

change llvm_unreachable message from "Unknown llvm.MachO.PlatformKind enum" to "Unknown llvm::MachO::PlatformKind enum"

Diff Detail

Unit TestsFailed

TimeTest
130 msx64 windows > LLVM.tools/llvm-cov::branch-templates.cpp

Event Timeline

spowell created this revision.May 11 2021, 9:19 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptMay 11 2021, 9:19 AM
spowell requested review of this revision.May 11 2021, 9:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2021, 9:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
spowell added a child revision: D101835: [llvm] llvm-tapi-diff.May 11 2021, 9:22 AM
spowell added a reviewer: JDevlieghere.
JDevlieghere accepted this revision.May 11 2021, 9:35 AM

LGTM

This revision is now accepted and ready to land.May 11 2021, 9:35 AM
This revision was landed with ongoing or failed builds.May 11 2021, 10:00 AM
Closed by commit rGcba508fb6787: [TextAPI] Reformat llvm_unreachable message (authored by spowell, committed by JDevlieghere). · Explain Why
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGcba508fb6787: [TextAPI] Reformat llvm_unreachable message.
Harbormaster completed remote builds in B103762: Diff 344430.May 11 2021, 10:05 AM
spowell removed a child revision: D101835: [llvm] llvm-tapi-diff.May 11 2021, 3:53 PM

Revision Contents

PathSize
llvm/
lib/
TextAPI/
4 lines

Diff 344430

llvm/lib/TextAPI/Platform.cpp

Show All 23 Lines default:
return Platform; return Platform;
case PlatformKind::iOS: case PlatformKind::iOS:
return WantSim ? PlatformKind::iOSSimulator : PlatformKind::iOS; return WantSim ? PlatformKind::iOSSimulator : PlatformKind::iOS;
case PlatformKind::tvOS: case PlatformKind::tvOS:
return WantSim ? PlatformKind::tvOSSimulator : PlatformKind::tvOS; return WantSim ? PlatformKind::tvOSSimulator : PlatformKind::tvOS;
case PlatformKind::watchOS: case PlatformKind::watchOS:
return WantSim ? PlatformKind::watchOSSimulator : PlatformKind::watchOS; return WantSim ? PlatformKind::watchOSSimulator : PlatformKind::watchOS;
} }
llvm_unreachable("Unknown llvm.MachO.PlatformKind enum"); llvm_unreachable("Unknown llvm::MachO::PlatformKind enum");
} }
PlatformKind mapToPlatformKind(const Triple &Target) { PlatformKind mapToPlatformKind(const Triple &Target) {
switch (Target.getOS()) { switch (Target.getOS()) {
default: default:
return PlatformKind::unknown; return PlatformKind::unknown;
case Triple::MacOSX: case Triple::MacOSX:
return PlatformKind::macOS; return PlatformKind::macOS;
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines case PlatformKind::iOSSimulator:
return "iOS Simulator"; return "iOS Simulator";
case PlatformKind::tvOSSimulator: case PlatformKind::tvOSSimulator:
return "tvOS Simulator"; return "tvOS Simulator";
case PlatformKind::watchOSSimulator: case PlatformKind::watchOSSimulator:
return "watchOS Simulator"; return "watchOS Simulator";
case PlatformKind::driverKit: case PlatformKind::driverKit:
return "DriverKit"; return "DriverKit";
} }
llvm_unreachable("Unknown llvm.MachO.PlatformKind enum"); llvm_unreachable("Unknown llvm::MachO::PlatformKind enum");
} }
PlatformKind getPlatformFromName(StringRef Name) { PlatformKind getPlatformFromName(StringRef Name) {
return StringSwitch<PlatformKind>(Name) return StringSwitch<PlatformKind>(Name)
.Case("macos", PlatformKind::macOS) .Case("macos", PlatformKind::macOS)
.Case("ios", PlatformKind::iOS) .Case("ios", PlatformKind::iOS)
.Case("tvos", PlatformKind::tvOS) .Case("tvos", PlatformKind::tvOS)
.Case("watchos", PlatformKind::watchOS) .Case("watchos", PlatformKind::watchOS)
Show All 11 Lines